Skip to content

Commit b06a552

Browse files
author
pritamdas99
committed
Update error log
Signed-off-by: pritamdas99 <pritam@appscode.com>
1 parent 310d80d commit b06a552

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

hazelcast/kubedb_client_builder.go

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -244,18 +244,18 @@ func (client *HZRestyClient) ChangeClusterState(state string) (string, error) {
244244
req.SetHeader("Content-Type", "application/json")
245245
req.SetBody(param)
246246
res, err := req.Post("/hazelcast/rest/management/cluster/changeState")
247+
if err != nil {
248+
klog.Error(err, "Failed to send http request")
249+
return "", err
250+
}
247251
if res != nil {
248-
if res.StatusCode() != 200 {
249-
klog.Error("stauscode is not 200")
250-
return "", errors.New("statuscode is not 200")
252+
if res.IsError() {
253+
klog.Error(res.Error())
254+
return "", errors.New(fmt.Sprintf("HTTP request failed: %v, StatusCode: %v", res.Error(), res.StatusCode()))
251255
}
252256
} else {
253257
return "", errors.New("response can not be nil")
254258
}
255-
if err != nil {
256-
klog.Error(err, res.StatusCode(), "Failed to send http request")
257-
return "", err
258-
}
259259
body := res.RawBody()
260260
responseBody := make(map[string]interface{})
261261
if err := json.NewDecoder(body).Decode(&responseBody); err != nil {
@@ -274,18 +274,18 @@ func (client *HZRestyClient) GetClusterState() (string, error) {
274274
req := client.Client.R().SetDoNotParseResponse(true)
275275

276276
res, err := req.Get("/hazelcast/health")
277+
if err != nil {
278+
klog.Error(err, "Failed to send http request")
279+
return "", err
280+
}
277281
if res != nil {
278-
if res.StatusCode() != 200 {
279-
klog.Error("stauscode is not 200")
280-
return "", errors.New("statuscode is not 200")
282+
if res.IsError() {
283+
klog.Error(res.Error())
284+
return "", errors.New(fmt.Sprintf("HTTP request failed: %v, StatusCode: %v", res.Error(), res.StatusCode()))
281285
}
282286
} else {
283287
return "", errors.New("response can not be nil")
284288
}
285-
if err != nil {
286-
klog.Error(err, res.StatusCode(), "Failed to send http request")
287-
return "", err
288-
}
289289
body := res.RawBody()
290290
responseBody := make(map[string]interface{})
291291
if err := json.NewDecoder(body).Decode(&responseBody); err != nil {

0 commit comments

Comments
 (0)