address comments

Signed-off-by: Zhiying Lin <[email protected]>

Author: zhiying-lin

charts/hub-agent/README.md

@@ -40,4 +40,4 @@ _See [helm install](https://helm.sh/docs/helm/helm_install/) for command documen
 | `ConcurrentResourceChangeSyncs`    | Max concurrent resourceChange reconcilers                                                                           | `20`                                             |
 | `logFileMaxSize`                  | Max log file size before rotation                                                                                   | `1000000`                                        |
 | `MaxFleetSizeSupported`            | Max number of member clusters supported                                                                             | `100`                                            |
-| `resourceSnapshotCreationInterval` | Interval for resource snapshot creation                                                                             | `1m`                                             |
+| `resourceSnapshotCreationInterval` | Interval for resource snapshot creation                                                                             | `30s`                                             |

charts/hub-agent/values.yaml

@@ -18,7 +18,7 @@ enableGuardRail: true
 webhookClientConnectionType: service
 forceDeleteWaitTime: 15m0s
 clusterUnhealthyThreshold: 3m0s
-resourceSnapshotCreationInterval: 1m0s
+resourceSnapshotCreationInterval: 30s
 
 namespace:
   fleet-system

cmd/hubagent/options/options.go

@@ -125,7 +125,7 @@ func NewOptions() *Options {
 		EnableStagedUpdateRunAPIs:        true,
 		EnablePprof:                      false,
 		PprofPort:                        6065,
-		ResourceSnapshotCreationInterval: 1 * time.Minute,
+		ResourceSnapshotCreationInterval: 30 * time.Second,
 	}
 }
 
@@ -172,7 +172,7 @@ func (o *Options) AddFlags(flags *flag.FlagSet) {
 	flags.BoolVar(&o.EnablePprof, "enable-pprof", false, "If set, the pprof profiling is enabled.")
 	flags.IntVar(&o.PprofPort, "pprof-port", 6065, "The port for pprof profiling.")
 	flags.BoolVar(&o.DenyModifyMemberClusterLabels, "deny-modify-member-cluster-labels", false, "If set, users not in the system:masters cannot modify member cluster labels.")
-	flags.DurationVar(&o.ResourceSnapshotCreationInterval, "resource-snapshot-creation-interval", 1*time.Minute, "The interval at which resource snapshots are created.")
+	flags.DurationVar(&o.ResourceSnapshotCreationInterval, "resource-snapshot-creation-interval", 30*time.Second, "The interval at which resource snapshots are created.")
 
 	o.RateLimiterOpts.AddFlags(flags)
 }

pkg/controllers/clusterresourceplacement/controller.go

@@ -206,9 +206,10 @@ func (r *Reconciler) handleUpdate(ctx context.Context, crp *fleetv1beta1.Cluster
 	createResourceSnapshotRes, latestResourceSnapshot, err := r.getOrCreateClusterResourceSnapshot(ctx, crp, envelopeObjCount,
 		&fleetv1beta1.ResourceSnapshotSpec{SelectedResources: selectedResources}, int(revisionLimit))
 	if err != nil {
-		// We don't requeue the request here immediately so that placement can keep tracking the rollout status.
 		return ctrl.Result{}, err
 	}
+
+	// We don't requeue the request here immediately so that placement can keep tracking the rollout status.
 	if createResourceSnapshotRes.Requeue {
 		latestResourceSnapshotKObj := klog.KObj(latestResourceSnapshot)
 		// We cannot create the resource snapshot immediately because of the resource snapshot creation interval.