Skip to content

Commit 0dc5784

Browse files
Update DeleteStrategy API comments based on review feedback
Co-authored-by: ryanzhang-oss <[email protected]>
1 parent 1ccf19a commit 0dc5784

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

apis/placement/v1beta1/clusterresourceplacement_types.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1325,16 +1325,16 @@ const (
13251325

13261326
// DeleteStrategy configures the deletion behavior when a placement is deleted.
13271327
type DeleteStrategy struct {
1328-
// PropagationPolicy controls how the deletion is propagated to placed resources.
1328+
// PropagationPolicy controls how we handle placed resources after the CRP no longer place it on the cluster
13291329
// Defaults to "Delete".
13301330
//
13311331
// Available options:
13321332
//
1333-
// * Delete: all placed resources on member clusters will be deleted when the
1334-
// ClusterResourcePlacement is deleted. This is the default behavior.
1333+
// * Delete: all placed resources on member clusters will be deleted when
1334+
// the placement is deleted. This is the default behavior.
13351335
//
13361336
// * Abandon: all placed resources on member clusters will be left intact (abandoned)
1337-
// when the ClusterResourcePlacement is deleted.
1337+
// when the placement is deleted.
13381338
//
13391339
// +kubebuilder:validation:Enum=Abandon;Delete
13401340
// +kubebuilder:default=Delete
@@ -1348,11 +1348,11 @@ type DeletePropagationPolicy string
13481348

13491349
const (
13501350
// DeletePropagationPolicyAbandon instructs Fleet to leave (abandon) all placed resources on member
1351-
// clusters when the ClusterResourcePlacement is deleted.
1351+
// clusters when the placement is deleted.
13521352
DeletePropagationPolicyAbandon DeletePropagationPolicy = "Abandon"
13531353

13541354
// DeletePropagationPolicyDelete instructs Fleet to delete all placed resources on member clusters
1355-
// when the ClusterResourcePlacement is deleted. This is the default behavior.
1355+
// when the placement is deleted. This is the default behavior.
13561356
DeletePropagationPolicyDelete DeletePropagationPolicy = "Delete"
13571357
)
13581358

apis/v1alpha1/zz_generated.deepcopy.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)