remove usage of SetStagedUpdateRunStatus

Signed-off-by: Arvind Thirumurugan <[email protected]>

Author: Arvind Thirumurugan

pkg/controllers/updaterun/initialization.go

@@ -134,7 +134,6 @@ func (r *Reconciler) validatePlacement(ctx context.Context, updateRun placementv
 	// Update the apply strategy in the updateRun status using interface methods
 	updateRunStatus := updateRun.GetStagedUpdateRunStatus()
 	updateRunStatus.ApplyStrategy = placementSpec.Strategy.ApplyStrategy
-	updateRun.SetStagedUpdateRunStatus(*updateRunStatus)
 
 	return placementKey, nil
 }
@@ -207,8 +206,6 @@ func (r *Reconciler) determinePolicySnapshot(
 		}
 	}
 	updateRunStatus.PolicyObservedClusterCount = clusterCount
-	updateRun.SetStagedUpdateRunStatus(*updateRunStatus)
-
 	klog.V(2).InfoS("Found the latest policy snapshot", "latestPolicySnapshotObj", policySnapshotRef, "observedClusterCount", updateRunStatus.PolicyObservedClusterCount, "stagedUpdateRunObj", updateRunRef)
 
 	if !condition.IsConditionStatusTrue(latestPolicySnapshot.GetCondition(string(placementv1beta1.PolicySnapshotScheduled)), latestPolicySnapshot.GetGeneration()) {
@@ -280,7 +277,6 @@ func (r *Reconciler) collectScheduledClusters(
 		// For pickAll policy, the observed cluster count is not included in the policy snapshot. We set it to the number of selected bindings.
 		// TODO (wantjian): refactor this part to update PolicyObservedClusterCount in one place.
 		updateRunStatus.PolicyObservedClusterCount = len(selectedBindings)
-		updateRun.SetStagedUpdateRunStatus(*updateRunStatus)
 	} else if updateRunStatus.PolicyObservedClusterCount != len(selectedBindings) {
 		countErr := controller.NewUnexpectedBehaviorError(fmt.Errorf("the number of selected bindings %d is not equal to the observed cluster count %d", len(selectedBindings), updateRunStatus.PolicyObservedClusterCount))
 		klog.ErrorS(countErr, "Failed to collect bindings", "placement", placementKey, "latestPolicySnapshotObj", policySnapshotRef, "stagedUpdateRunObj", updateRunRef)
@@ -329,7 +325,6 @@ func (r *Reconciler) generateStagesByStrategy(
 	updateRunStatus := updateRun.GetStagedUpdateRunStatus()
 	updateStrategySpec := updateStrategy.GetStagedUpdateStrategySpec()
 	updateRunStatus.StagedUpdateStrategySnapshot = updateStrategySpec
-	updateRun.SetStagedUpdateRunStatus(*updateRunStatus)
 
 	// Remove waitTime from the updateRun status for AfterStageTask for type Approval.
 	removeWaitTimeFromUpdateRunStatus(updateRun)
@@ -351,12 +346,10 @@ func (r *Reconciler) generateStagesByStrategy(
 	})
 
 	// Update deletion stage status using interface methods
-	updateRunStatus = updateRun.GetStagedUpdateRunStatus()
 	updateRunStatus.DeletionStageStatus = &placementv1beta1.StageUpdatingStatus{
 		StageName: placementv1beta1.UpdateRunDeleteStageName,
 		Clusters:  toBeDeletedClusters,
 	}
-	updateRun.SetStagedUpdateRunStatus(*updateRunStatus)
 	return nil
 }
 
@@ -478,7 +471,6 @@ func (r *Reconciler) computeRunStageStatus(
 
 	// Update the stages status using interface methods
 	updateRunStatus.StagesStatus = stagesStatus
-	updateRun.SetStagedUpdateRunStatus(*updateRunStatus)
 
 	// Check if the clusters are all placed.
 	if len(allPlacedClusters) != len(allSelectedClusters) {
@@ -593,8 +585,6 @@ func (r *Reconciler) recordOverrideSnapshots(ctx context.Context, placementKey t
 		}
 	}
 
-	// Update the status back using interface method
-	updateRun.SetStagedUpdateRunStatus(*updateRunStatus)
 	return nil
 }