Skip to content

Commit 426cfc3

Browse files
committed
minor fixes
Signed-off-by: Britania Rodriguez Reyes <[email protected]>
1 parent fe09842 commit 426cfc3

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

apis/placement/v1beta1/clusterresourceplacement_types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ type PlacementSpec struct {
150150
RevisionHistoryLimit *int32 `json:"revisionHistoryLimit,omitempty"`
151151

152152
// EnableStatusProxy indicates whether a PlacementStatusProxy object should be created to mirror the placement status.
153-
// When enabled, PlacementStatusProxy objects will be created in the same namespaces selected by the ResourceSelectors.
153+
// When enabled, PlacementStatusProxy objects will be created in the same namespace selected by the ResourceSelectors.
154154
// This allows namespace-scoped access to the cluster-scoped ClusterResourcePlacement status.
155155
// Defaults to false.
156156
// +kubebuilder:default=false

apis/placement/v1beta1/commons.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,10 @@ const (
6161
// cluster.
6262
WorkFinalizer = fleetPrefix + "work-cleanup"
6363

64+
// PlacementStatusProxyCleanupFinalizer is a finalizer added by the controller to all PlacementStatusProxy objects, to make sure
65+
// that the controller can react to PlacementStatusProxy deletions if necessary.
66+
PlacementStatusProxyCleanupFinalizer = fleetPrefix + "placement-status-proxy-cleanup"
67+
6468
// PlacementTrackingLabel points to the placement that creates this resource binding.
6569
// TODO: migrate the label content to "parent-placement" to work with both the PR and CRP
6670
PlacementTrackingLabel = fleetPrefix + "parent-CRP"

0 commit comments

Comments
 (0)