Skip to content

Commit 4386f48

Browse files
author
Arvind Thirumurugan
committed
remove approval-request-controller from kubefleet
Signed-off-by: Arvind Thirumurugan <[email protected]>
1 parent 36847bb commit 4386f48

File tree

3 files changed

+19
-22
lines changed

3 files changed

+19
-22
lines changed

charts/hub-agent/templates/crds/placement.kubernetes-fleet.io_metriccollectorreports.yaml

Lines changed: 0 additions & 1 deletion
This file was deleted.

charts/hub-agent/templates/crds/placement.kubernetes-fleet.io_metriccollectors.yaml

Lines changed: 0 additions & 1 deletion
This file was deleted.

cmd/hubagent/workload/setup.go

Lines changed: 19 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ import (
3333
clusterv1beta1 "github.com/kubefleet-dev/kubefleet/apis/cluster/v1beta1"
3434
placementv1beta1 "github.com/kubefleet-dev/kubefleet/apis/placement/v1beta1"
3535
"github.com/kubefleet-dev/kubefleet/cmd/hubagent/options"
36-
"github.com/kubefleet-dev/kubefleet/pkg/controllers/approvalrequest"
3736
"github.com/kubefleet-dev/kubefleet/pkg/controllers/bindingwatcher"
3837
"github.com/kubefleet-dev/kubefleet/pkg/controllers/clusterinventory/clusterprofile"
3938
"github.com/kubefleet-dev/kubefleet/pkg/controllers/clusterresourceplacementeviction"
@@ -330,25 +329,25 @@ func SetupControllers(ctx context.Context, wg *sync.WaitGroup, mgr ctrl.Manager,
330329
}
331330
}
332331

333-
// Set up the cluster approval request controller
334-
klog.Info("Setting up clusterApprovalRequest controller")
335-
if err = (&approvalrequest.Reconciler{
336-
Client: mgr.GetClient(),
337-
}).SetupWithManagerForClusterApprovalRequest(mgr); err != nil {
338-
klog.ErrorS(err, "Unable to set up clusterApprovalRequest controller")
339-
return err
340-
}
341-
342-
// Set up the approval request controller for namespaced resources
343-
if opts.EnableResourcePlacement {
344-
klog.Info("Setting up approvalRequest controller")
345-
if err = (&approvalrequest.Reconciler{
346-
Client: mgr.GetClient(),
347-
}).SetupWithManagerForApprovalRequest(mgr); err != nil {
348-
klog.ErrorS(err, "Unable to set up approvalRequest controller")
349-
return err
350-
}
351-
}
332+
// // Set up the cluster approval request controller
333+
// klog.Info("Setting up clusterApprovalRequest controller")
334+
// if err = (&approvalrequest.Reconciler{
335+
// Client: mgr.GetClient(),
336+
// }).SetupWithManagerForClusterApprovalRequest(mgr); err != nil {
337+
// klog.ErrorS(err, "Unable to set up clusterApprovalRequest controller")
338+
// return err
339+
// }
340+
341+
// // Set up the approval request controller for namespaced resources
342+
// if opts.EnableResourcePlacement {
343+
// klog.Info("Setting up approvalRequest controller")
344+
// if err = (&approvalrequest.Reconciler{
345+
// Client: mgr.GetClient(),
346+
// }).SetupWithManagerForApprovalRequest(mgr); err != nil {
347+
// klog.ErrorS(err, "Unable to set up approvalRequest controller")
348+
// return err
349+
// }
350+
// }
352351
}
353352

354353
// Set up the work generator

0 commit comments

Comments
 (0)