Skip to content

Commit 504ba69

Browse files
committed
use another label
Signed-off-by: Wantong Jiang <[email protected]>
1 parent f925413 commit 504ba69

File tree

5 files changed

+21
-21
lines changed

5 files changed

+21
-21
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -217,11 +217,11 @@ e2e-tests: setup-clusters
217217

218218
# Tests that can be run in parallel
219219
e2e-tests-parallel: setup-clusters
220-
cd ./test/e2e && ginkgo --label-filter="!custom && !serial" -v -p .
220+
cd ./test/e2e && ginkgo --label-filter="!custom && !mc-op" -v -p .
221221

222222
# Tests that must be run serially
223223
e2e-tests-serial: setup-clusters
224-
cd ./test/e2e && ginkgo --label-filter="!custom && serial" -v .
224+
cd ./test/e2e && ginkgo --label-filter="!custom && mc-op" -v .
225225

226226
e2e-tests-custom: setup-clusters
227227
cd ./test/e2e && ginkgo --label-filter="custom" -v -p .

test/e2e/fleet_guard_rail_test.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ var _ = Describe("fleet guard rail tests for deny fleet MC CREATE operations", f
8282
})
8383
})
8484

85-
var _ = Describe("fleet guard rail tests for allow/deny fleet MC UPDATE, DELETE operations", Label("serial"), Serial, Ordered, func() {
85+
var _ = Describe("fleet guard rail tests for allow/deny fleet MC UPDATE, DELETE operations", Label("mc-op"), Serial, Ordered, func() {
8686
mcName := fmt.Sprintf(mcNameTemplate, GinkgoParallelProcess())
8787

8888
BeforeAll(func() {
@@ -346,7 +346,7 @@ var _ = Describe("fleet guard rail tests for allow upstream MC CREATE, DELETE op
346346
})
347347
})
348348

349-
var _ = Describe("fleet guard rail tests for allow/deny upstream MC UPDATE operations", Label("serial"), Serial, Ordered, func() {
349+
var _ = Describe("fleet guard rail tests for allow/deny upstream MC UPDATE operations", Label("mc-op"), Serial, Ordered, func() {
350350
mcName := fmt.Sprintf(mcNameTemplate, GinkgoParallelProcess())
351351

352352
BeforeAll(func() {
@@ -499,7 +499,7 @@ var _ = Describe("fleet guard rail tests for allow/deny upstream MC UPDATE opera
499499
})
500500
})
501501

502-
var _ = Describe("fleet guard rail tests for IMC UPDATE operation, in fleet-member prefixed namespace with user not in MC identity", Label("serial"), Serial, Ordered, func() {
502+
var _ = Describe("fleet guard rail tests for IMC UPDATE operation, in fleet-member prefixed namespace with user not in MC identity", Label("mc-op"), Serial, Ordered, func() {
503503
mcName := fmt.Sprintf(mcNameTemplate, GinkgoParallelProcess())
504504
imcNamespace := fmt.Sprintf(utils.NamespaceNameFormat, mcName)
505505

@@ -578,7 +578,7 @@ var _ = Describe("fleet guard rail tests for IMC UPDATE operation, in fleet-memb
578578
})
579579
})
580580

581-
var _ = Describe("fleet guard rail tests for IMC UPDATE operation, in fleet-member prefixed namespace with user in MC identity", Label("serial"), Serial, Ordered, func() {
581+
var _ = Describe("fleet guard rail tests for IMC UPDATE operation, in fleet-member prefixed namespace with user in MC identity", Label("mc-op"), Serial, Ordered, func() {
582582
mcName := fmt.Sprintf(mcNameTemplate, GinkgoParallelProcess())
583583
imcNamespace := fmt.Sprintf(utils.NamespaceNameFormat, mcName)
584584

@@ -640,7 +640,7 @@ var _ = Describe("fleet guard rail tests for IMC UPDATE operation, in fleet-memb
640640
})
641641
})
642642

643-
var _ = Describe("fleet guard rail for UPDATE work operations, in fleet prefixed namespace with user not in MC identity", Label("serial"), Serial, Ordered, func() {
643+
var _ = Describe("fleet guard rail for UPDATE work operations, in fleet prefixed namespace with user not in MC identity", Label("mc-op"), Serial, Ordered, func() {
644644
mcName := fmt.Sprintf(mcNameTemplate, GinkgoParallelProcess())
645645
imcNamespace := fmt.Sprintf(utils.NamespaceNameFormat, mcName)
646646
workName := fmt.Sprintf(workNamespaceNameTemplate, GinkgoParallelProcess())
@@ -731,7 +731,7 @@ var _ = Describe("fleet guard rail for UPDATE work operations, in fleet prefixed
731731
})
732732
})
733733

734-
var _ = Describe("fleet guard rail for UPDATE work operations, in fleet prefixed namespace with user in MC identity", Label("serial"), Serial, Ordered, func() {
734+
var _ = Describe("fleet guard rail for UPDATE work operations, in fleet prefixed namespace with user in MC identity", Label("mc-op"), Serial, Ordered, func() {
735735
mcName := fmt.Sprintf(mcNameTemplate, GinkgoParallelProcess())
736736
imcNamespace := fmt.Sprintf(utils.NamespaceNameFormat, mcName)
737737
workName := fmt.Sprintf(workNamespaceNameTemplate, GinkgoParallelProcess())
@@ -796,7 +796,7 @@ var _ = Describe("fleet guard rail for UPDATE work operations, in fleet prefixed
796796
})
797797
})
798798

799-
var _ = Describe("fleet guard rail networking E2Es", Label("serial"), Serial, Ordered, func() {
799+
var _ = Describe("fleet guard rail networking E2Es", Label("mc-op"), Serial, Ordered, func() {
800800
Context("deny request to modify fleet networking resources in fleet member namespaces, for user not in member cluster identity", func() {
801801
mcName := fmt.Sprintf(mcNameTemplate, GinkgoParallelProcess())
802802
iseName := fmt.Sprintf(internalServiceExportNameTemplate, GinkgoParallelProcess())
@@ -916,7 +916,7 @@ var _ = Describe("fleet guard rail networking E2Es", Label("serial"), Serial, Or
916916
})
917917
})
918918

919-
var _ = Describe("fleet guard rail restrict internal fleet resources from being created in fleet/kube pre-fixed namespaces", Label("serial"), Serial, Ordered, func() {
919+
var _ = Describe("fleet guard rail restrict internal fleet resources from being created in fleet/kube pre-fixed namespaces", Label("mc-op"), Serial, Ordered, func() {
920920
Context("deny request to CREATE IMC in fleet-system namespace", func() {
921921
It("should deny CREATE operation on internal member cluster resource in fleet-system namespace for invalid user", func() {
922922
imc := clusterv1beta1.InternalMemberCluster{

test/e2e/join_and_leave_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ const (
4343
)
4444

4545
// Note that this container cannot run in parallel with other containers.
46-
var _ = Describe("Test member cluster join and leave flow", Label("serial"), Ordered, Serial, func() {
46+
var _ = Describe("Test member cluster join and leave flow", Label("mc-op"), Ordered, Serial, func() {
4747
crpName := fmt.Sprintf(crpNameTemplate, GinkgoParallelProcess())
4848
workNamespaceName := fmt.Sprintf(workNamespaceNameTemplate, GinkgoParallelProcess())
4949
internalServiceExportName := fmt.Sprintf("internal-service-export-%d", GinkgoParallelProcess())
@@ -79,7 +79,7 @@ var _ = Describe("Test member cluster join and leave flow", Label("serial"), Ord
7979
}
8080
})
8181

82-
Context("Test cluster join and leave flow with CRP not deleted", Label("serial"), Ordered, Serial, func() {
82+
Context("Test cluster join and leave flow with CRP not deleted", Label("mc-op"), Ordered, Serial, func() {
8383
It("Create the test resources in the namespace", createWrappedResourcesForEnvelopTest)
8484

8585
It("Create the CRP that select the name space and place it to all clusters", func() {
@@ -245,8 +245,8 @@ var _ = Describe("Test member cluster join and leave flow", Label("serial"), Ord
245245
})
246246
})
247247

248-
var _ = Describe("Test member cluster force delete flow", Label("serial"), Ordered, Serial, func() {
249-
Context("Test cluster join and leave flow with member agent down and force delete member cluster", Label("serial"), Ordered, Serial, func() {
248+
var _ = Describe("Test member cluster force delete flow", Label("mc-op"), Ordered, Serial, func() {
249+
Context("Test cluster join and leave flow with member agent down and force delete member cluster", Label("mc-op"), Ordered, Serial, func() {
250250
It("Simulate the member agent going down in member cluster", func() {
251251
updateMemberAgentDeploymentReplicas(memberCluster3WestProdClient, 0)
252252
})

test/e2e/scheduler_watchers_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ const (
6161
// Note that most of the cases below are Serial ones, as they manipulate the list of member
6262
// clusters in the test environment directly, which may incur side effects when running in
6363
// parallel with other test cases.
64-
var _ = Describe("responding to specific member cluster changes", Label("serial"), func() {
64+
var _ = Describe("responding to specific member cluster changes", Label("mc-op"), func() {
6565
Context("cluster becomes eligible for PickAll CRPs, just joined", Serial, Ordered, func() {
6666
crpName := fmt.Sprintf(crpNameTemplate, GinkgoParallelProcess())
6767

test/e2e/updaterun_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -907,7 +907,7 @@ var _ = Describe("test CRP rollout with staged update run", func() {
907907
})
908908

909909
// Note that this container cannot run in parallel with other containers.
910-
var _ = Describe("Test member cluster join and leave flow with updateRun", Label("serial"), Ordered, Serial, func() {
910+
var _ = Describe("Test member cluster join and leave flow with updateRun", Label("mc-op"), Ordered, Serial, func() {
911911
crpName := fmt.Sprintf(crpNameTemplate, GinkgoParallelProcess())
912912
strategyName := fmt.Sprintf(updateRunStrategyNameTemplate, GinkgoParallelProcess())
913913
var strategy *placementv1beta1.ClusterStagedUpdateStrategy
@@ -1008,7 +1008,7 @@ var _ = Describe("Test member cluster join and leave flow with updateRun", Label
10081008
ensureUpdateRunStrategyDeletion(strategyName)
10091009
})
10101010

1011-
Context("UpdateRun should delete the binding of a left cluster but resources are kept", Label("serial"), Ordered, Serial, func() {
1011+
Context("UpdateRun should delete the binding of a left cluster but resources are kept", Label("mc-op"), Ordered, Serial, func() {
10121012
It("Should validate binding for member cluster 1 is set to Unscheduled", func() {
10131013
bindingUnscheduledActual := bindingStateActual(crpName, allMemberClusterNames[0], placementv1beta1.BindingStateUnscheduled)
10141014
Eventually(bindingUnscheduledActual, eventuallyDuration, eventuallyInterval).Should(Succeed(), "Failed to mark binding for member cluster %s as unscheduled", allMemberClusterNames[0])
@@ -1056,7 +1056,7 @@ var _ = Describe("Test member cluster join and leave flow with updateRun", Label
10561056
})
10571057
})
10581058

1059-
Context("Rejoin a member cluster when resources are not changed", Label("serial"), Ordered, Serial, func() {
1059+
Context("Rejoin a member cluster when resources are not changed", Label("mc-op"), Ordered, Serial, func() {
10601060
It("Should be able to rejoin member cluster 1", func() {
10611061
setMemberClusterToJoin(allMemberClusters[0])
10621062
checkIfMemberClusterHasJoined(allMemberClusters[0])
@@ -1084,7 +1084,7 @@ var _ = Describe("Test member cluster join and leave flow with updateRun", Label
10841084
})
10851085
})
10861086

1087-
Context("Rejoin a member cluster when resources are changed", Label("serial"), Ordered, Serial, func() {
1087+
Context("Rejoin a member cluster when resources are changed", Label("mc-op"), Ordered, Serial, func() {
10881088
var newConfigMap corev1.ConfigMap
10891089

10901090
It("Generate a new configMap", func() {
@@ -1134,7 +1134,7 @@ var _ = Describe("Test member cluster join and leave flow with updateRun", Label
11341134
})
11351135
})
11361136

1137-
Context("Rejoin a member cluster after orphaned resources are deleted on the member cluster", Label("serial"), Ordered, Serial, func() {
1137+
Context("Rejoin a member cluster after orphaned resources are deleted on the member cluster", Label("mc-op"), Ordered, Serial, func() {
11381138
It("Should delete the orphaned resources on member cluster 1", func() {
11391139
cleanWorkResourcesOnCluster(allMemberClusters[0])
11401140
})
@@ -1166,7 +1166,7 @@ var _ = Describe("Test member cluster join and leave flow with updateRun", Label
11661166
})
11671167
})
11681168

1169-
Context("Rejoin a member cluster and change to rollout CRP with rollingUpdate", Label("serial"), Ordered, Serial, func() {
1169+
Context("Rejoin a member cluster and change to rollout CRP with rollingUpdate", Label("mc-op"), Ordered, Serial, func() {
11701170
It("Should be able to rejoin member cluster 1", func() {
11711171
setMemberClusterToJoin(allMemberClusters[0])
11721172
checkIfMemberClusterHasJoined(allMemberClusters[0])

0 commit comments

Comments
 (0)