feat: refactor rollout controller (#115)

Author: ryanzhang-oss

.github/.copilot/breadcrumbs/2025-06-24-0900-rollout-controller-binding-interface-refactor.md

@@ -20,6 +20,8 @@ import (
 	"k8s.io/apimachinery/pkg/api/meta"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"sigs.k8s.io/controller-runtime/pkg/client"
+
+	"github.com/kubefleet-dev/kubefleet/apis"
 )
 
 const (
@@ -52,7 +54,7 @@ type BindingStatusGetterSetter interface {
 // A BindingObj offers an abstract way to work with fleet binding objects.
 // +kubebuilder:object:generate=false
 type BindingObj interface {
-	client.Object
+	apis.ConditionedObj
 	BindingSpecGetterSetter
 	BindingStatusGetterSetter
 }

apis/placement/v1beta1/binding_types.go

@@ -22,6 +22,8 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/util/intstr"
 	"sigs.k8s.io/controller-runtime/pkg/client"
+
+	"github.com/kubefleet-dev/kubefleet/apis"
 )
 
 const (
@@ -58,7 +60,7 @@ type PlacementStatusGetterSetter interface {
 // PlacementObj offers the functionality to work with fleet placement object.
 // +kubebuilder:object:generate=false
 type PlacementObj interface {
-	client.Object
+	apis.ConditionedObj
 	PlacementSpecGetterSetter
 	PlacementStatusGetterSetter
 }

apis/placement/v1beta1/clusterresourceplacement_types.go

@@ -20,6 +20,8 @@ import (
 	"k8s.io/apimachinery/pkg/api/meta"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"sigs.k8s.io/controller-runtime/pkg/client"
+
+	"github.com/kubefleet-dev/kubefleet/apis"
 )
 
 const (
@@ -57,7 +59,7 @@ type PolicySnapshotStatusGetterSetter interface {
 // A PolicySnapshotObj offers an abstract way to work with a fleet policy snapshot object.
 // +kubebuilder:object:generate=false
 type PolicySnapshotObj interface {
-	client.Object
+	apis.ConditionedObj
 	PolicySnapshotSpecGetterSetter
 	PolicySnapshotStatusGetterSetter
 }

apis/placement/v1beta1/policysnapshot_types.go

@@ -21,6 +21,8 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 	"sigs.k8s.io/controller-runtime/pkg/client"
+
+	"github.com/kubefleet-dev/kubefleet/apis"
 )
 
 const (
@@ -74,7 +76,7 @@ type ResourceSnapshotStatusGetterSetter interface {
 // A ResourceSnapshotObj offers an abstract way to work with a resource snapshot object.
 // +kubebuilder:object:generate=false
 type ResourceSnapshotObj interface {
-	client.Object
+	apis.ConditionedObj
 	ResourceSnapshotSpecGetterSetter
 	ResourceSnapshotStatusGetterSetter
 }

apis/placement/v1beta1/resourcesnapshot_types.go

@@ -0,0 +1 @@
+../../../../config/crd/bases/placement.kubernetes-fleet.io_clusterresourceenvelopes.yaml

charts/hub-agent/templates/crds/placement.kubernetes-fleet.io_clusterresourceenvelopes.yaml

@@ -0,0 +1 @@
+../../../../config/crd/bases/placement.kubernetes-fleet.io_resourcebindings.yaml

charts/hub-agent/templates/crds/placement.kubernetes-fleet.io_clusterresourceenvelopes.yaml

@@ -0,0 +1 @@
+../../../../config/crd/bases/placement.kubernetes-fleet.io_resourceenvelopes.yaml