fix: do not emit unexpectedError when getting objs with dynamic client (#382)

Author: jwtty

pkg/controllers/workapplier/preprocess.go

@@ -489,7 +489,7 @@ func (r *Reconciler) removeOneLeftOverManifest(
 		return nil
 	case err != nil:
 		// Failed to retrieve the object from the member cluster.
-		wrappedErr := controller.NewAPIServerError(true, err)
+		wrappedErr := controller.NewAPIServerError(false, err) // false as dynamic client is non-caching.
 		return fmt.Errorf("failed to retrieve the object from the member cluster (gvr=%+v, manifestObj=%+v): %w", gvr, klog.KRef(manifestNamespace, manifestName), wrappedErr)
 	case inMemberClusterObj.GetDeletionTimestamp() != nil:
 		// The object has been marked for deletion; no further action is needed.

pkg/controllers/workapplier/process.go

@@ -229,7 +229,7 @@ func (r *Reconciler) findInMemberClusterObjectFor(
 		return false
 	default:
 		// An unexpected error has occurred.
-		wrappedErr := controller.NewAPIServerError(true, err)
+		wrappedErr := controller.NewAPIServerError(false, err) // false as dynamic client is non-caching.
 		bundle.applyOrReportDiffErr = fmt.Errorf("failed to find the corresponding object for the manifest object in the member cluster: %w", wrappedErr)
 		bundle.applyOrReportDiffResTyp = ApplyOrReportDiffResTypeFailedToFindObjInMemberCluster
 		klog.ErrorS(wrappedErr,