fix: deployment availability check (#47)

Author: Arvindthiru

pkg/controllers/workapplier/availability_tracker.go

@@ -133,7 +133,8 @@ func trackDeploymentAvailability(inMemberClusterObj *unstructured.Unstructured)
 	}
 	if deploy.Status.ObservedGeneration == deploy.Generation &&
 		requiredReplicas == deploy.Status.AvailableReplicas &&
-		requiredReplicas == deploy.Status.UpdatedReplicas {
+		requiredReplicas == deploy.Status.UpdatedReplicas &&
+		deploy.Status.UnavailableReplicas == 0 {
 		klog.V(2).InfoS("Deployment is available", "deployment", klog.KObj(inMemberClusterObj))
 		return ManifestProcessingAvailabilityResultTypeAvailable, nil
 	}

pkg/controllers/workapplier/availability_tracker_test.go

@@ -212,6 +212,17 @@ func TestTrackDeploymentAvailability(t *testing.T) {
 		UpdatedReplicas:   2,
 	}
 
+	// new replicaset due to max surge, is not ready. old replicaset is still ready.
+	unavailableDeployWithMoreReplicasThanRequired := deploy.DeepCopy()
+	unavailableDeployWithMoreReplicasThanRequired.Spec.Replicas = ptr.To(int32(1))
+	unavailableDeployWithMoreReplicasThanRequired.Status = appsv1.DeploymentStatus{
+		// we don't use this field in the availability check, adding for test case clarity.
+		Replicas:            2,
+		AvailableReplicas:   1,
+		UpdatedReplicas:     1,
+		UnavailableReplicas: 1,
+	}
+
 	testCases := []struct {
 		name                                         string
 		deploy                                       *appsv1.Deployment
@@ -242,6 +253,11 @@ func TestTrackDeploymentAvailability(t *testing.T) {
 			deploy: unavailableDeployWithNotEnoughUpdatedReplicas,
 			wantManifestProcessingAvailabilityResultType: ManifestProcessingAvailabilityResultTypeNotYetAvailable,
 		},
+		{
+			name:   "unavailable deployment with unavailable replicas",
+			deploy: unavailableDeployWithMoreReplicasThanRequired,
+			wantManifestProcessingAvailabilityResultType: ManifestProcessingAvailabilityResultTypeNotYetAvailable,
+		},
 	}
 
 	for _, tc := range testCases {