refactor the scheduler

Ryan Zhang · Ryan Zhang · commit 8f578ea2d452 · 2025-06-27T15:27:24.000-07:00
Signed-off-by: Ryan Zhang &lt;zhangryan@microsoft.com&gt;
diff --git a/pkg/scheduler/framework/frameworkutils.go b/pkg/scheduler/framework/frameworkutils.go
@@ -765,7 +765,11 @@ func crossReferenceValidTargetsWithBindings(
 	for _, binding := range obsolete {
 		if _, ok := validTargetMap[binding.GetBindingSpec().TargetCluster]; !ok {
 			// The cluster is no longer a valid target; mark the binding as unscheduled.
-			toDelete = append(toDelete, binding)
+			if crb, ok := binding.(*placementv1beta1.ClusterResourceBinding); ok {
+				toDelete = append(toDelete, crb)
+			} else {
+				return nil, nil, nil, controller.NewUnexpectedBehaviorError(fmt.Errorf("unexpected binding type: %T", binding))
+			}
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -765,7 +765,11 @@ func crossReferenceValidTargetsWithBindings(`
`765`	`765`	`for _, binding := range obsolete {`
`766`	`766`	`if _, ok := validTargetMap[binding.GetBindingSpec().TargetCluster]; !ok {`
`767`	`767`	`// The cluster is no longer a valid target; mark the binding as unscheduled.`
`768`		`- toDelete = append(toDelete, binding)`
	`768`	`+ if crb, ok := binding.(*placementv1beta1.ClusterResourceBinding); ok {`
	`769`	`+ toDelete = append(toDelete, crb)`
	`770`	`+ } else {`
	`771`	`+ return nil, nil, nil, controller.NewUnexpectedBehaviorError(fmt.Errorf("unexpected binding type: %T", binding))`
	`772`	`+ }`
`769`	`773`	`}`
`770`	`774`	`}`
`771`	`775`