make rollout strategy immutable

Signed-off-by: Britania Rodriguez Reyes <[email protected]>

Author: britaniar

apis/placement/v1beta1/clusterresourceplacement_types.go

@@ -524,9 +524,9 @@ const (
 type RolloutStrategy struct {
 	// Type of rollout. The only supported types are "RollingUpdate" and "External".
 	// Default is "RollingUpdate".
-	// +kubebuilder:validation:Optional
 	// +kubebuilder:default=RollingUpdate
 	// +kubebuilder:validation:Enum=RollingUpdate;External
+	// +kubebuilder:validation:XValidation:rule="!(self != oldSelf)",message="rollout strategy type is immutable"
 	Type RolloutStrategyType `json:"type,omitempty"`
 
 	// Rolling update config params. Present only if RolloutStrategyType = RollingUpdate.

config/crd/bases/placement.kubernetes-fleet.io_clusterresourceplacements.yaml

@@ -2482,6 +2482,9 @@ spec:
                     - RollingUpdate
                     - External
                     type: string
+                    x-kubernetes-validations:
+                    - message: rollout strategy type is immutable
+                      rule: '!(self != oldSelf)'
                 type: object
             required:
             - resourceSelectors

config/crd/bases/placement.kubernetes-fleet.io_resourceplacements.yaml

@@ -992,6 +992,9 @@ spec:
                     - RollingUpdate
                     - External
                     type: string
+                    x-kubernetes-validations:
+                    - message: rollout strategy type is immutable
+                      rule: '!(self != oldSelf)'
                 type: object
             required:
             - resourceSelectors

test/apis/placement/v1beta1/api_validation_integration_test.go

@@ -166,6 +166,15 @@ var _ = Describe("Test placement v1beta1 API validation", func() {
 			Expect(errors.As(err, &statusErr)).To(BeTrue(), fmt.Sprintf("Update CRP call produced error %s. Error type wanted is %s.", reflect.TypeOf(err), reflect.TypeOf(&k8sErrors.StatusError{})))
 			Expect(statusErr.ErrStatus.Message).Should(MatchRegexp("placement type is immutable"))
 		})
+
+		It("should deny update of RolloutStrategy type", func() {
+			// Default RolloutStrategy type is RollingUpdate
+			crp.Spec.Strategy.Type = placementv1beta1.ExternalRolloutStrategyType
+			err := hubClient.Update(ctx, &crp)
+			var statusErr *k8sErrors.StatusError
+			Expect(errors.As(err, &statusErr)).To(BeTrue(), fmt.Sprintf("Update CRP call produced error %s. Error type wanted is %s.", reflect.TypeOf(err), reflect.TypeOf(&k8sErrors.StatusError{})))
+			Expect(statusErr.ErrStatus.Message).Should(MatchRegexp("rollout strategy type is immutable"))
+		})
 	})
 
 	Context("Test ClusterResourcePlacement StatusReportingScope validation - create, allow cases", func() {