fix

Ryan Zhang · Ryan Zhang · commit 9a1ad020fadd · 2025-07-24T15:13:07.000-07:00
diff --git a/pkg/controllers/clusterresourceplacement/resource_selector.go b/pkg/controllers/clusterresourceplacement/resource_selector.go
@@ -121,7 +121,7 @@ func convertResourceSelector(old []fleetv1alpha1.ClusterResourceSelector) []flee
 }
 
 // gatherSelectedResource gets all the resources according to the resource selector.
-// TODO: treat the RP differently
+// TODO: treat the RP selector differently to not allow RP to select cluster scoped resources
 func (r *Reconciler) gatherSelectedResource(placement string, selectors []fleetv1beta1.ClusterResourceSelector) ([]*unstructured.Unstructured, error) {
 	var resources []*unstructured.Unstructured
 	var resourceMap = make(map[fleetv1beta1.ResourceIdentifier]bool)

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ func convertResourceSelector(old []fleetv1alpha1.ClusterResourceSelector) []flee`
`121`	`121`	`}`
`122`	`122`
`123`	`123`	`// gatherSelectedResource gets all the resources according to the resource selector.`
`124`		`-// TODO: treat the RP differently`
	`124`	`+// TODO: treat the RP selector differently to not allow RP to select cluster scoped resources`
`125`	`125`	`func (r Reconciler) gatherSelectedResource(placement string, selectors []fleetv1beta1.ClusterResourceSelector) ([]unstructured.Unstructured, error) {`
`126`	`126`	`var resources []*unstructured.Unstructured`
`127`	`127`	`var resourceMap = make(map[fleetv1beta1.ResourceIdentifier]bool)`