enum for stateful set test yaml

Signed-off-by: Wei Weng <Wei.Weng@microsoft.com>

Author: Wei Weng

test/e2e/enveloped_object_placement_test.go

@@ -226,7 +226,7 @@ var _ = Describe("placing wrapped resources using a CRP", func() {
 			// read the test resources.
 			readDeploymentTestManifest(&testDeployment)
 			readDaemonSetTestManifest(&testDaemonSet)
-			readStatefulSetTestManifest(&testStatefulSet, true)
+			readStatefulSetTestManifest(&testStatefulSet, StatefulSetWithStorage)
 			readEnvelopeResourceTestManifest(&testResourceEnvelope)
 		})
 

test/e2e/resource_placement_hub_workload_test.go

@@ -39,7 +39,7 @@ var _ = Describe("placing workloads using a CRP with PickAll policy", Label("res
 		// Read the test manifests
 		readDeploymentTestManifest(&testDeployment)
 		readDaemonSetTestManifest(&testDaemonSet)
-		readStatefulSetTestManifest(&testStatefulSet, false)
+		readStatefulSetTestManifest(&testStatefulSet, StatefulSetWithStorage)
 		workNamespace := appNamespace()
 
 		// Create namespace and workloads

test/e2e/resource_placement_rollout_test.go

@@ -69,7 +69,7 @@ var _ = Describe("placing namespaced scoped resources using a RP with rollout",
 		testDaemonSet = appv1.DaemonSet{}
 		readDaemonSetTestManifest(&testDaemonSet)
 		testStatefulSet = appv1.StatefulSet{}
-		readStatefulSetTestManifest(&testStatefulSet, false)
+		readStatefulSetTestManifest(&testStatefulSet, StatefulSetBasic)
 		testService = corev1.Service{}
 		readServiceTestManifest(&testService)
 		testJob = batchv1.Job{}

test/e2e/resources/test-statefulset.yaml test/e2e/resources/statefulset-basic.yamltest/e2e/resources/test-statefulset.yaml renamed to test/e2e/resources/statefulset-basic.yaml

@@ -0,0 +1,28 @@
+apiVersion: apps/v1
+kind: StatefulSet
+metadata:
+  name: test-ss
+spec:
+  selector:
+    matchLabels:
+      app: test-ss
+  serviceName: "test-ss-svc"
+  replicas: 2
+  template:
+    metadata:
+      labels:
+        app: test-ss
+    spec:
+      terminationGracePeriodSeconds: 10
+      containers:
+      - name: pause
+        image: k8s.gcr.io/pause:3.8
+  volumeClaimTemplates:
+  - metadata:
+      name: test-ss-pvc
+    spec:
+      accessModes: [ "ReadWriteOnce" ]
+      storageClassName: "standard"
+      resources:
+        requests:
+          storage: 100Mi

…e/resources/statefulset-with-volume.yaml …sources/statefulset-invalid-storage.yamltest/e2e/resources/statefulset-with-volume.yaml renamed to test/e2e/resources/statefulset-invalid-storage.yaml test/e2e/resources/statefulset-with-volume.yaml renamed to test/e2e/resources/statefulset-invalid-storage.yaml

@@ -342,7 +342,7 @@ var _ = Describe("placing wrapped resources using a CRP", Ordered, func() {
 
 		BeforeAll(func() {
 			// Create the test resources.
-			readStatefulSetTestManifest(&testStatefulSet, false)
+			readStatefulSetTestManifest(&testStatefulSet, StatefulSetBasic)
 			readEnvelopeResourceTestManifest(&testStatefulSetEnvelope)
 			wantSelectedResources = []placementv1beta1.ResourceIdentifier{
 				{

test/e2e/resources/statefulset-with-storage.yaml

@@ -57,6 +57,18 @@ import (
 	"github.com/kubefleet-dev/kubefleet/test/e2e/framework"
 )
 
+// StatefulSetVariant represents different StatefulSet configurations for testing
+type StatefulSetVariant int
+
+const (
+	// StatefulSetBasic is a StatefulSet without any persistent volume claims
+	StatefulSetBasic StatefulSetVariant = iota
+	// StatefulSetInvalidStorage is a StatefulSet with a non-existent storage class
+	StatefulSetInvalidStorage
+	// StatefulSetWithStorage is a StatefulSet with a valid standard storage class
+	StatefulSetWithStorage
+)
+
 var (
 	croTestAnnotationKey    = "cro-test-annotation"
 	croTestAnnotationValue  = "cro-test-annotation-val"
@@ -1532,13 +1544,18 @@ func readDaemonSetTestManifest(testDaemonSet *appsv1.DaemonSet) {
 	Expect(err).Should(Succeed())
 }
 
-func readStatefulSetTestManifest(testStatefulSet *appsv1.StatefulSet, withVolume bool) {
+func readStatefulSetTestManifest(testStatefulSet *appsv1.StatefulSet, variant StatefulSetVariant) {
 	By("Read the statefulSet resource")
-	if withVolume {
-		Expect(utils.GetObjectFromManifest("resources/statefulset-with-volume.yaml", testStatefulSet)).Should(Succeed())
-	} else {
-		Expect(utils.GetObjectFromManifest("resources/test-statefulset.yaml", testStatefulSet)).Should(Succeed())
-	}
+	var manifestPath string
+	switch variant {
+	case StatefulSetBasic:
+		manifestPath = "resources/statefulset-basic.yaml"
+	case StatefulSetInvalidStorage:
+		manifestPath = "resources/statefulset-invalid-storage.yaml"
+	case StatefulSetWithStorage:
+		manifestPath = "resources/statefulset-with-storage.yaml"
+	}
+	Expect(utils.GetObjectFromManifest(manifestPath, testStatefulSet)).Should(Succeed())
 }
 
 func readServiceTestManifest(testService *corev1.Service) {