only show top 10 missing clusters

Signed-off-by: Wantong Jiang <[email protected]>

Author: jwtty

pkg/controllers/updaterun/initialization.go

@@ -389,10 +389,11 @@ func (r *Reconciler) computeRunStageStatus(
 		}
 		// Sort the missing clusters by their names to generate a stable error message.
 		sort.Strings(missingClusters)
-		missingClustersStr := strings.Join(missingClusters, ", ")
-		klog.ErrorS(missingErr, "Clusters are missing in any stage", "clusters", missingClustersStr, "clusterStagedUpdateStrategy", updateStrategyName, "clusterStagedUpdateRun", updateRunRef)
+		klog.ErrorS(missingErr, "Clusters are missing in any stage", "clusters", strings.Join(missingClusters, ", "), "clusterStagedUpdateStrategy", updateStrategyName, "clusterStagedUpdateRun", updateRunRef)
+		// Only show the first 10 missing clusters in the CRP status.
+		missingClusters = missingClusters[:min(10, len(missingClusters))]
 		// no more retries here.
-		return fmt.Errorf("%w: %s: %s", errInitializedFailed, missingErr.Error(), missingClustersStr)
+		return fmt.Errorf("%w: %s (showing up to 10): %s", errInitializedFailed, missingErr.Error(), strings.Join(missingClusters, ", "))
 	}
 	return nil
 }

pkg/controllers/updaterun/initialization_integration_test.go

@@ -617,7 +617,7 @@ var _ = Describe("Updaterun initialization tests", func() {
 				Expect(k8sClient.Create(ctx, updateRun)).To(Succeed())
 
 				By("Validating the initialization failed")
-				validateFailedInitCondition(ctx, updateRun, "some clusters are not placed in any stage: cluster-0, cluster-2, cluster-4, cluster-6, cluster-8")
+				validateFailedInitCondition(ctx, updateRun, "some clusters are not placed in any stage (showing up to 10): cluster-0, cluster-2, cluster-4, cluster-6, cluster-8")
 			})
 
 			It("Should select all scheduled clusters if labelSelector is empty and select no clusters if labelSelector is nil", func() {