update to use a default value for RequeueAfter

Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>

Author: britaniar

pkg/controllers/updaterun/controller.go

@@ -124,7 +124,7 @@ func (r *Reconciler) Reconcile(ctx context.Context, req runtime.Request) (runtim
 			// Update the status to indicate that the updateRun is initializing.
 			// Requeue immediately to continue with initialization.
 			klog.V(2).InfoS("The updateRun is initializing", "state", state, "updateRun", runObjRef)
-			return runtime.Result{RequeueAfter: 1}, r.recordUpdateRunInitializing(ctx, updateRun)
+			return runtime.Result{RequeueAfter: utils.DefaultRequeueAfterDuration}, r.recordUpdateRunInitializing(ctx, updateRun)
 		}
 
 		var initErr error
@@ -188,9 +188,9 @@ func (r *Reconciler) Reconcile(ctx context.Context, req runtime.Request) (runtim
 			return runtime.Result{}, execErr
 		}
 		if waitTime == 0 {
-			// If update run is not finished and waitTime is zero, the waitTime needs to be update to a non-zero value
+			// If update run is not finished and the waitTime needs to be update to a non-zero value or default requeue duration,
 			// as we are using RequeueAfter only since Requeue is deprecated.
-			return runtime.Result{RequeueAfter: 1}, nil
+			return runtime.Result{RequeueAfter: utils.DefaultRequeueAfterDuration}, nil
 		}
 		return runtime.Result{RequeueAfter: waitTime}, nil
 	}

pkg/controllers/updaterun/execution.go

@@ -35,6 +35,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/client"
 
 	placementv1beta1 "github.com/kubefleet-dev/kubefleet/apis/placement/v1beta1"
+	"github.com/kubefleet-dev/kubefleet/pkg/utils"
 	bindingutils "github.com/kubefleet-dev/kubefleet/pkg/utils/binding"
 	"github.com/kubefleet-dev/kubefleet/pkg/utils/condition"
 	"github.com/kubefleet-dev/kubefleet/pkg/utils/controller"
@@ -418,7 +419,7 @@ func (r *Reconciler) checkAfterStageTasksStatus(ctx context.Context, updatingSta
 		}
 	}
 	if passed {
-		afterStageWaitTime = 0
+		afterStageWaitTime = utils.DefaultRequeueAfterDuration
 	}
 	return passed, afterStageWaitTime, nil
 }

pkg/utils/common.go

@@ -54,6 +54,15 @@ import (
 	"github.com/kubefleet-dev/kubefleet/pkg/utils/informer"
 )
 
+const (
+	// DefaultRequeueAfterDuration is the default duration after which to requeue a reconcile request.
+	// This is used when a controller wants to requeue immediately. A small duration is used to mimic immediate requeue
+	// that Controller-Runtimes deprecated Requeue=true previously provided.
+	// For more details, see: https://github.com/kubernetes-sigs/controller-runtime/pull/3107
+	// The value needs to be small enough to avoid noticeable delay, but greater than 0 as RequeueAfter=0 is treated as no requeue.
+	DefaultRequeueAfterDuration = time.Microsecond * 1
+)
+
 const (
 	kubePrefix                 = "kube-"
 	fleetPrefix                = "fleet-"