update computeRunStageStatus function

Signed-off-by: Arvind Thirumurugan <[email protected]>

Author: Arvind Thirumurugan

.github/.copilot/breadcrumbs/2025-09-25-1430-initialize-refactor.md

@@ -309,8 +309,63 @@ func (r *Reconciler) collectScheduledClusters(
 
 **Compatibility Note**: The `initialize` function includes temporary type conversion logic to maintain compatibility with other functions (`generateStagesByStrategy`, `recordOverrideSnapshots`) that haven't been refactored yet. This demonstrates the incremental nature of the interface-based refactoring.
 
+### Phase 7: computeRunStageStatus Refactor ✅
+
+**Target**: `computeRunStageStatus` function - computes cluster stages based on StagedUpdateStrategy
+
+**Implementation**: Applied interface-based pattern consistently:
+
+**Before**:
+```go
+func (r *Reconciler) computeRunStageStatus(
+    ctx context.Context,
+    scheduledBindings []*placementv1beta1.ClusterResourceBinding,
+    updateRun *placementv1beta1.ClusterStagedUpdateRun,
+) error {
+    // Direct field access
+    updateStrategyName := updateRun.Spec.StagedUpdateStrategyName
+    allSelectedClusters[binding.Spec.TargetCluster] = struct{}{}
+    for _, stage := range updateRun.Status.StagedUpdateStrategySnapshot.Stages {
+        // Direct status modification
+        updateRun.Status.StagesStatus = stagesStatus
+    }
+}
+```
+
+**After**:
+```go
+func (r *Reconciler) computeRunStageStatus(
+    ctx context.Context,
+    scheduledBindings []placementv1beta1.BindingObj,
+    updateRun placementv1beta1.StagedUpdateRunObj,
+) error {
+    // Interface-based access
+    updateRunSpec := updateRun.GetStagedUpdateRunSpec()
+    updateRunStatus := updateRun.GetStagedUpdateRunStatus()
+    updateStrategyName := updateRunSpec.StagedUpdateStrategyName
+    bindingSpec := binding.GetBindingSpec()
+    allSelectedClusters[bindingSpec.TargetCluster] = struct{}{}
+    for _, stage := range updateRunStatus.StagedUpdateStrategySnapshot.Stages {
+        // Interface-based status modification
+        updateRunStatus.StagesStatus = stagesStatus
+        updateRun.SetStagedUpdateRunStatus(*updateRunStatus)
+    }
+}
+```
+
+**Key Improvements**:
+1. **Generic Interface Parameters**: Uses `[]BindingObj` and `StagedUpdateRunObj` instead of concrete types
+2. **Interface-Based Access**: Uses `GetStagedUpdateRunSpec()`, `GetStagedUpdateRunStatus()`, `GetBindingSpec()` 
+3. **Interface-Based Status Updates**: Uses `SetStagedUpdateRunStatus()` instead of direct field assignment
+4. **Type Conversion Integration**: Uses `controller.ConvertCRBArrayToBindingObjs()` in caller
+5. **Generic Logging**: Updated terminology from cluster-specific to generic
+
+**Integration**: The `generateStagesByStrategy` function now converts concrete binding arrays to interfaces before calling `computeRunStageStatus`, maintaining compatibility while enabling interface-based processing.
+
 ## Current Status
 - ✅ `validatePlacement`: Fully generic, uses utility functions and interfaces
 - ✅ `determinePolicySnapshot`: Fully generic, uses utility functions and interfaces, unnecessary switch removed
 - ✅ `collectScheduledClusters`: Fully generic, uses utility functions and interfaces
-- ⚠️ `initialize`: Still takes concrete ClusterStagedUpdateRun type, but now calls interface-based functions
+- ✅ `computeRunStageStatus`: Fully generic, uses interface-based access patterns
+- ⚠️ `initialize`: Still takes concrete ClusterStagedUpdateRun type, but now calls interface-based functions
+- ⚠️ `generateStagesByStrategy`: Still takes concrete types but converts to interfaces for `computeRunStageStatus`

pkg/controllers/updaterun/initialization.go

@@ -322,7 +322,9 @@ func (r *Reconciler) generateStagesByStrategy(
 	removeWaitTimeFromUpdateRunStatus(updateRun)
 
 	// Compute the update stages.
-	if err := r.computeRunStageStatus(ctx, scheduledBindings, updateRun); err != nil {
+	// Convert concrete binding arrays to interface arrays
+	scheduledBindingObjs := controller.ConvertCRBArrayToBindingObjs(scheduledBindings)
+	if err := r.computeRunStageStatus(ctx, scheduledBindingObjs, updateRun); err != nil {
 		return err
 	}
 	toBeDeletedClusters := make([]placementv1beta1.ClusterUpdatingStatus, len(toBeDeletedBindings))
@@ -341,25 +343,30 @@ func (r *Reconciler) generateStagesByStrategy(
 	return nil
 }
 
-// computeRunStageStatus computes the stages based on the ClusterStagedUpdateStrategy and records them in the ClusterStagedUpdateRun status.
+// computeRunStageStatus computes the stages based on the StagedUpdateStrategy and records them in the StagedUpdateRun status.
 func (r *Reconciler) computeRunStageStatus(
 	ctx context.Context,
-	scheduledBindings []*placementv1beta1.ClusterResourceBinding,
-	updateRun *placementv1beta1.ClusterStagedUpdateRun,
+	scheduledBindings []placementv1beta1.BindingObj,
+	updateRun placementv1beta1.StagedUpdateRunObj,
 ) error {
 	updateRunRef := klog.KObj(updateRun)
-	updateStrategyName := updateRun.Spec.StagedUpdateStrategyName
+
+	// Use interface methods to access updateRun data
+	updateRunSpec := updateRun.GetStagedUpdateRunSpec()
+	updateRunStatus := updateRun.GetStagedUpdateRunStatus()
+	updateStrategyName := updateRunSpec.StagedUpdateStrategyName
 
 	// Map to track clusters and ensure they appear in one and only one stage.
 	allSelectedClusters := make(map[string]struct{}, len(scheduledBindings))
 	allPlacedClusters := make(map[string]struct{})
 	for _, binding := range scheduledBindings {
-		allSelectedClusters[binding.Spec.TargetCluster] = struct{}{}
+		bindingSpec := binding.GetBindingSpec()
+		allSelectedClusters[bindingSpec.TargetCluster] = struct{}{}
 	}
-	stagesStatus := make([]placementv1beta1.StageUpdatingStatus, 0, len(updateRun.Status.StagedUpdateStrategySnapshot.Stages))
+	stagesStatus := make([]placementv1beta1.StageUpdatingStatus, 0, len(updateRunStatus.StagedUpdateStrategySnapshot.Stages))
 
-	// Apply the label selectors from the ClusterStagedUpdateStrategy to filter the clusters.
-	for _, stage := range updateRun.Status.StagedUpdateStrategySnapshot.Stages {
+	// Apply the label selectors from the StagedUpdateStrategy to filter the clusters.
+	for _, stage := range updateRunStatus.StagedUpdateStrategySnapshot.Stages {
 		if err := validateAfterStageTask(stage.AfterStageTasks); err != nil {
 			klog.ErrorS(err, "Failed to validate the after stage tasks", "clusterStagedUpdateStrategy", updateStrategyName, "stage name", stage.Name, "clusterStagedUpdateRun", updateRunRef)
 			// no more retries here.
@@ -439,12 +446,15 @@ func (r *Reconciler) computeRunStageStatus(
 		for i, task := range stage.AfterStageTasks {
 			curStageUpdatingStatus.AfterStageTaskStatus[i].Type = task.Type
 			if task.Type == placementv1beta1.AfterStageTaskTypeApproval {
-				curStageUpdatingStatus.AfterStageTaskStatus[i].ApprovalRequestName = fmt.Sprintf(placementv1beta1.ApprovalTaskNameFmt, updateRun.Name, stage.Name)
+				curStageUpdatingStatus.AfterStageTaskStatus[i].ApprovalRequestName = fmt.Sprintf(placementv1beta1.ApprovalTaskNameFmt, updateRun.GetName(), stage.Name)
 			}
 		}
 		stagesStatus = append(stagesStatus, curStageUpdatingStatus)
 	}
-	updateRun.Status.StagesStatus = stagesStatus
+
+	// Update the stages status using interface methods
+	updateRunStatus.StagesStatus = stagesStatus
+	updateRun.SetStagedUpdateRunStatus(*updateRunStatus)
 
 	// Check if the clusters are all placed.
 	if len(allPlacedClusters) != len(allSelectedClusters) {