Skip to content

Commit cfdab36

Browse files
committed
fix minors
Signed-off-by: Zhiying Lin <[email protected]>
1 parent 57a489f commit cfdab36

File tree

4 files changed

+5
-3494
lines changed

4 files changed

+5
-3494
lines changed

charts/hub-agent/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,5 +40,5 @@ _See [helm install](https://helm.sh/docs/helm/helm_install/) for command documen
4040
| `ConcurrentResourceChangeSyncs` | Max concurrent resourceChange reconcilers | `20` |
4141
| `logFileMaxSize` | Max log file size before rotation | `1000000` |
4242
| `MaxFleetSizeSupported` | Max number of member clusters supported | `100` |
43-
| `resourceSnapshotCreationInterval` | Interval for resource snapshot creation | `1m` |
44-
| `resourceChangesCollectionDuration` | Interval for resource snapshot creation | `1m`
43+
| `resourceSnapshotCreationInterval` | Interval for resource snapshot creation | `30s` |
44+
| `resourceChangesCollectionDuration` | Interval for resource snapshot creation | `30s`

charts/hub-agent/values.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ forceDeleteWaitTime: 15m0s
2020
clusterUnhealthyThreshold: 3m0s
2121
resourceSnapshotCreationInterval: 30s
2222
resourceChangesCollectionDuration: 30s
23+
2324
namespace:
2425
fleet-system
2526

cmd/hubagent/options/options.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,8 @@ type Options struct {
104104
PprofPort int
105105
// DenyModifyMemberClusterLabels indicates if the member cluster labels cannot be modified by groups (excluding system:masters)
106106
DenyModifyMemberClusterLabels bool
107-
// ResourceSnapshotCreationInterval is the interval at which resource snapshots are created.
107+
// ResourceSnapshotCreationInterval is the interval at which resource snapshots could be created.
108+
// Whether the resource snapshot is created or not depends on the both ResourceSnapshotCreationInterval and resourceChangesCollectionDuration.
108109
ResourceSnapshotCreationInterval time.Duration
109110
// ResourceChangesCollectionDuration is the duration for collecting resource changes into one snapshot.
110111
ResourceChangesCollectionDuration time.Duration

0 commit comments

Comments
 (0)