Skip to content

Commit df8dea3

Browse files
author
Ryan Zhang
committed
edit crd comments
Signed-off-by: Ryan Zhang <[email protected]>
1 parent 04bf569 commit df8dea3

10 files changed

+30
-20
lines changed

config/crd/bases/placement.kubernetes-fleet.io_clusterresourcebindings.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -542,8 +542,8 @@ spec:
542542
managed by Fleet (i.e., specified in the hub cluster manifest). This is the default
543543
option.
544544
545-
Note that this option would revert any ad-hoc changes made on the member cluster side in
546-
the managed fields; if you would like to make temporary edits on the member cluster side
545+
Note that this option would revert any ad-hoc changes made on the member cluster side in the
546+
managed fields; if you would like to make temporary edits on the member cluster side
547547
in the managed fields, switch to IfNotDrifted option. Note that changes in unmanaged
548548
fields will be left alone; if you use the FullDiff compare option, such changes will
549549
be reported as drifts.

config/crd/bases/placement.kubernetes-fleet.io_clusterresourceoverrides.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ spec:
5353
We only support Name selector for now.
5454
items:
5555
description: |-
56-
ClusterResourceSelector is used to select cluster scoped resources as the target resources to be placed.
56+
ResourceSelectorTerm is used to select resources as the target resources to be placed.
5757
All the fields are `ANDed`. In other words, a resource must match all the fields to be selected.
5858
properties:
5959
group:

config/crd/bases/placement.kubernetes-fleet.io_clusterresourceoverridesnapshots.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ spec:
6767
We only support Name selector for now.
6868
items:
6969
description: |-
70-
ClusterResourceSelector is used to select cluster scoped resources as the target resources to be placed.
70+
ResourceSelectorTerm is used to select resources as the target resources to be placed.
7171
All the fields are `ANDed`. In other words, a resource must match all the fields to be selected.
7272
properties:
7373
group:

config/crd/bases/placement.kubernetes-fleet.io_clusterresourceplacements.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1589,7 +1589,7 @@ spec:
15891589
You can have 1-100 selectors.
15901590
items:
15911591
description: |-
1592-
ClusterResourceSelector is used to select cluster scoped resources as the target resources to be placed.
1592+
ResourceSelectorTerm is used to select resources as the target resources to be placed.
15931593
All the fields are `ANDed`. In other words, a resource must match all the fields to be selected.
15941594
properties:
15951595
group:
@@ -1667,7 +1667,7 @@ spec:
16671667
revisionHistoryLimit:
16681668
default: 10
16691669
description: |-
1670-
The number of old ClusterSchedulingPolicySnapshot or ClusterResourceSnapshot resources to retain to allow rollback.
1670+
The number of old SchedulingPolicySnapshot or ResourceSnapshot resources to retain to allow rollback.
16711671
This is a pointer to distinguish between explicit zero and not specified.
16721672
Defaults to 10.
16731673
format: int32
@@ -1807,8 +1807,8 @@ spec:
18071807
managed by Fleet (i.e., specified in the hub cluster manifest). This is the default
18081808
option.
18091809
1810-
Note that this option would revert any ad-hoc changes made on the member cluster side in
1811-
the managed fields; if you would like to make temporary edits on the member cluster side
1810+
Note that this option would revert any ad-hoc changes made on the member cluster side in the
1811+
managed fields; if you would like to make temporary edits on the member cluster side
18121812
in the managed fields, switch to IfNotDrifted option. Note that changes in unmanaged
18131813
fields will be left alone; if you use the FullDiff compare option, such changes will
18141814
be reported as drifts.

config/crd/bases/placement.kubernetes-fleet.io_clusterresourcesnapshots.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ spec:
4040
Each snapshot MUST have the following labels:
4141
- `CRPTrackingLabel` which points to its owner CRP.
4242
- `ResourceIndexLabel` which is the index of the snapshot group.
43+
44+
The first snapshot of the index group MAY have the following labels:
4345
- `IsLatestSnapshotLabel` which indicates whether the snapshot is the latest one.
4446
4547
All the snapshots within the same index group must have the same ResourceIndexLabel.
@@ -50,6 +52,9 @@ spec:
5052
5153
Each snapshot (excluding the first snapshot) MUST have the following annotations:
5254
- `SubindexOfResourceSnapshotAnnotation` to store the subindex of resource snapshot in the group.
55+
56+
Snapshot may have the following annotations to indicate the time of next resourceSnapshot candidate detected by the controller:
57+
- `NextResourceSnapshotCandidateDetectionTimeAnnotation` to store the time of next resourceSnapshot candidate detected by the controller.
5358
properties:
5459
apiVersion:
5560
description: |-
@@ -186,6 +191,9 @@ spec:
186191
187192
Each snapshot (excluding the first snapshot) MUST have the following annotations:
188193
- `SubindexOfResourceSnapshotAnnotation` to store the subindex of resource snapshot in the group.
194+
195+
Snapshot may have the following annotations to indicate the time of next resourceSnapshot candidate detected by the controller:
196+
- `NextResourceSnapshotCandidateDetectionTimeAnnotation` to store the time of next resourceSnapshot candidate detected by the controller.
189197
properties:
190198
apiVersion:
191199
description: |-

config/crd/bases/placement.kubernetes-fleet.io_clusterstagedupdateruns.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -235,8 +235,8 @@ spec:
235235
managed by Fleet (i.e., specified in the hub cluster manifest). This is the default
236236
option.
237237
238-
Note that this option would revert any ad-hoc changes made on the member cluster side in
239-
the managed fields; if you would like to make temporary edits on the member cluster side
238+
Note that this option would revert any ad-hoc changes made on the member cluster side in the
239+
managed fields; if you would like to make temporary edits on the member cluster side
240240
in the managed fields, switch to IfNotDrifted option. Note that changes in unmanaged
241241
fields will be left alone; if you use the FullDiff compare option, such changes will
242242
be reported as drifts.
@@ -1315,8 +1315,8 @@ spec:
13151315
managed by Fleet (i.e., specified in the hub cluster manifest). This is the default
13161316
option.
13171317
1318-
Note that this option would revert any ad-hoc changes made on the member cluster side in
1319-
the managed fields; if you would like to make temporary edits on the member cluster side
1318+
Note that this option would revert any ad-hoc changes made on the member cluster side in the
1319+
managed fields; if you would like to make temporary edits on the member cluster side
13201320
in the managed fields, switch to IfNotDrifted option. Note that changes in unmanaged
13211321
fields will be left alone; if you use the FullDiff compare option, such changes will
13221322
be reported as drifts.

config/crd/bases/placement.kubernetes-fleet.io_resourcebindings.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,8 +190,8 @@ spec:
190190
managed by Fleet (i.e., specified in the hub cluster manifest). This is the default
191191
option.
192192
193-
Note that this option would revert any ad-hoc changes made on the member cluster side in
194-
the managed fields; if you would like to make temporary edits on the member cluster side
193+
Note that this option would revert any ad-hoc changes made on the member cluster side in the
194+
managed fields; if you would like to make temporary edits on the member cluster side
195195
in the managed fields, switch to IfNotDrifted option. Note that changes in unmanaged
196196
fields will be left alone; if you use the FullDiff compare option, such changes will
197197
be reported as drifts.

config/crd/bases/placement.kubernetes-fleet.io_resourceplacements.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -524,7 +524,7 @@ spec:
524524
You can have 1-100 selectors.
525525
items:
526526
description: |-
527-
ClusterResourceSelector is used to select cluster scoped resources as the target resources to be placed.
527+
ResourceSelectorTerm is used to select resources as the target resources to be placed.
528528
All the fields are `ANDed`. In other words, a resource must match all the fields to be selected.
529529
properties:
530530
group:
@@ -602,7 +602,7 @@ spec:
602602
revisionHistoryLimit:
603603
default: 10
604604
description: |-
605-
The number of old ClusterSchedulingPolicySnapshot or ClusterResourceSnapshot resources to retain to allow rollback.
605+
The number of old SchedulingPolicySnapshot or ResourceSnapshot resources to retain to allow rollback.
606606
This is a pointer to distinguish between explicit zero and not specified.
607607
Defaults to 10.
608608
format: int32
@@ -742,8 +742,8 @@ spec:
742742
managed by Fleet (i.e., specified in the hub cluster manifest). This is the default
743743
option.
744744
745-
Note that this option would revert any ad-hoc changes made on the member cluster side in
746-
the managed fields; if you would like to make temporary edits on the member cluster side
745+
Note that this option would revert any ad-hoc changes made on the member cluster side in the
746+
managed fields; if you would like to make temporary edits on the member cluster side
747747
in the managed fields, switch to IfNotDrifted option. Note that changes in unmanaged
748748
fields will be left alone; if you use the FullDiff compare option, such changes will
749749
be reported as drifts.

config/crd/bases/placement.kubernetes-fleet.io_resourcesnapshots.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ spec:
4040
Each snapshot MUST have the following labels:
4141
- `CRPTrackingLabel` which points to its owner resource placement.
4242
- `ResourceIndexLabel` which is the index of the snapshot group.
43+
44+
The first snapshot of the index group MAY have the following labels:
4345
- `IsLatestSnapshotLabel` which indicates whether the snapshot is the latest one.
4446
4547
All the snapshots within the same index group must have the same ResourceIndexLabel.

config/crd/bases/placement.kubernetes-fleet.io_works.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -433,8 +433,8 @@ spec:
433433
managed by Fleet (i.e., specified in the hub cluster manifest). This is the default
434434
option.
435435
436-
Note that this option would revert any ad-hoc changes made on the member cluster side in
437-
the managed fields; if you would like to make temporary edits on the member cluster side
436+
Note that this option would revert any ad-hoc changes made on the member cluster side in the
437+
managed fields; if you would like to make temporary edits on the member cluster side
438438
in the managed fields, switch to IfNotDrifted option. Note that changes in unmanaged
439439
fields will be left alone; if you use the FullDiff compare option, such changes will
440440
be reported as drifts.

0 commit comments

Comments
 (0)