Skip to content

Commit abaf149

Browse files
committed
fix syntax and naming
Signed-off-by: kunal-511 <[email protected]>
1 parent 9f285c3 commit abaf149

File tree

3 files changed

+13
-12
lines changed

3 files changed

+13
-12
lines changed

tests/helm_kustomize_compare.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -306,10 +306,11 @@ def compare_manifests(kustomize_file: str, helm_file: str, component: str, scena
306306
component = sys.argv[3]
307307
scenario = sys.argv[4]
308308
namespace = sys.argv[5] if len(sys.argv) > 5 and not sys.argv[5].startswith('--') else ""
309-
310-
if component not in ["katib", "model-registry", "kserve-models-web-app", "notebook-controller", "kubeflow-pipelines"]:
309+
verbose = '--verbose' in sys.argv
310+
311+
if component not in ["katib", "model-registry", "kserve-models-web-app", "notebook-controller", "pipelines"]:
311312
print(f"ERROR: Unknown component: {component}")
312-
print("Supported components: katib, model-registry, kserve-models-web-app, notebook-controller","kubeflow-pipelines")
313+
print("Supported components: katib, model-registry, kserve-models-web-app, notebook-controller, pipelines")
313314
sys.exit(1)
314315

315316
success = compare_manifests(kustomize_file, helm_file, component, scenario, namespace, verbose)

tests/helm_kustomize_compare.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ ROOT_DIR="$(dirname "$SCRIPT_DIR")"
1111
if [[ -z "$COMPONENT" ]]; then
1212
echo "ERROR: Component is required"
1313
echo "Usage: $0 <component> <scenario>"
14-
echo "Components: katib, model-registry, kserve-models-web-app, notebook-controller, kubeflow-pipelines"
14+
echo "Components: katib, model-registry, kserve-models-web-app, notebook-controller, pipelines"
1515
exit 1
1616
fi
1717

@@ -158,8 +158,8 @@ case "$COMPONENT" in
158158
["production"]="kubeflow"
159159
)
160160
;;
161-
"kubeflow-pipelines")
162-
CHART_DIR="$ROOT_DIR/experimental/helm/charts/kubeflow-pipelines"
161+
"pipelines")
162+
CHART_DIR="$ROOT_DIR/experimental/helm/charts/pipelines"
163163
MANIFESTS_DIR="$ROOT_DIR/applications/pipeline/upstream"
164164

165165
declare -A KUSTOMIZE_PATHS=(
@@ -243,7 +243,7 @@ case "$COMPONENT" in
243243

244244
*)
245245
echo "ERROR: Unknown component: $COMPONENT"
246-
echo "Supported components: katib, model-registry, kserve-models-web-app, notebook-controller, kubeflow-pipelines""
246+
echo "Supported components: katib, model-registry, kserve-models-web-app, notebook-controller, pipelines"
247247
exit 1
248248
;;
249249
esac
@@ -305,7 +305,7 @@ else
305305
--namespace "$NAMESPACE" \
306306
--include-crds \
307307
--values "$HELM_VALUES_ARG" > "$HELM_OUTPUT"
308-
elif [[ "$COMPONENT" == "kubeflow-pipelines" ]]; then
308+
elif [[ "$COMPONENT" == "pipelines" ]]; then
309309
if [[ "$SCENARIO" == "generic" ]]; then
310310
helm template pipeline . \
311311
--namespace "$NAMESPACE" \

tests/helm_kustomize_compare_all.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ declare -A COMPONENT_SCENARIOS=(
1313
["model-registry"]="base overlay-postgres overlay-db controller-manager controller-rbac controller-default controller-prometheus controller-network-policy ui-base ui-standalone ui-integrated ui-istio istio csi"
1414
["kserve-models-web-app"]="base kubeflow"
1515
["notebook-controller"]="base kubeflow standalone"
16-
["kubeflow-pipelines"]="platform-agnostic aws gcp azure multi-user generic dev plain plain-multi-user platform-agnostic-emissary platform-agnostic-multi-user platform-agnostic-multi-user-emissary platform-agnostic-multi-user-legacy platform-agnostic-postgresql"
16+
["pipelines"]="platform-agnostic aws gcp azure multi-user generic dev plain plain-multi-user platform-agnostic-emissary platform-agnostic-multi-user platform-agnostic-multi-user-emissary platform-agnostic-multi-user-legacy platform-agnostic-postgresql"
1717
)
1818

1919
test_component() {
@@ -51,7 +51,7 @@ if [[ "$COMPONENT" == "all" ]]; then
5151
declare -a passed_components=()
5252
declare -a failed_components=()
5353

54-
for comp in katib model-registry kserve-models-web-app notebook-controller kubeflow-pipelines; do
54+
for comp in katib model-registry kserve-models-web-app notebook-controller pipelines; do
5555
if test_component "$comp"; then
5656
passed_components+=("$comp")
5757
else
@@ -80,7 +80,7 @@ elif [[ "$COMPONENT" == "help" ]] || [[ "$COMPONENT" == "--help" ]] || [[ "$COMP
8080
echo " model-registry Test Model Registry scenarios"
8181
echo " kserve-models-web-app Test KServe Models Web App scenarios"
8282
echo " notebook-controller Test Notebook Controller scenarios"
83-
echo " kubeflow-pipelines Test Kubeflow Pipelines scenarios"
83+
echo " pipelines Test Kubeflow Pipelines scenarios"
8484
echo ""
8585
echo "Examples:"
8686
echo " $0 # Test all components"
@@ -101,7 +101,7 @@ elif [[ "${COMPONENT_SCENARIOS[$COMPONENT]:-}" ]]; then
101101

102102
else
103103
echo "ERROR: Unknown component: $COMPONENT"
104-
echo "Supported components: katib, model-registry, kserve-models-web-app, notebook-controller,kubeflow-pipelines, all"
104+
echo "Supported components: katib, model-registry, kserve-models-web-app, notebook-controller,pipelines, all"
105105
echo "Use '$0 help' for more information."
106106
exit 1
107107
fi

0 commit comments

Comments
 (0)