Skip to content

Commit 31c36f0

Browse files
committed
remove third-party components code/references
Signed-off-by: sduvvuri1603 <sduvvuri@redhat.com>
1 parent e369e34 commit 31c36f0

File tree

3 files changed

+17
-25
lines changed

3 files changed

+17
-25
lines changed

.github/workflows/compile-and-deps.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,14 @@ jobs:
1717
- name: Set up Python
1818
uses: actions/setup-python@v5
1919
with:
20-
python-version: "3.10"
20+
python-version: "3.11"
2121

2222
- name: Install uv
2323
uses: astral-sh/setup-uv@v3
2424
with:
2525
enable-cache: true
2626
cache-dependency-glob: |
2727
pyproject.toml
28-
third_party/pyproject.toml
2928
3029
- name: Install dependencies
3130
run: |

scripts/compile_check.py

Lines changed: 14 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -75,9 +75,9 @@ def parse_args(argv: Optional[Sequence[str]] = None) -> argparse.Namespace:
7575
parser = argparse.ArgumentParser(description="Compile Kubeflow components and pipelines.")
7676
parser.add_argument(
7777
"--tier",
78-
choices=["core", "third_party", "all"],
78+
choices=["core", "all"],
7979
default="all",
80-
help="Limit validation to a specific tier (default: all).",
80+
help="Limit validation to core tier only or run across all core assets (default: all).",
8181
)
8282
parser.add_argument(
8383
"--path",
@@ -113,26 +113,20 @@ def configure_logging(verbose: bool) -> None:
113113

114114
def discover_metadata_files(tier: str) -> List[Tuple[Path, str, str]]:
115115
"""Return a list of (metadata_path, tier, target_kind)."""
116-
search_roots: Dict[str, List[Tuple[Path, str]]] = {
117-
"core": [
118-
(REPO_ROOT / "components", "component"),
119-
(REPO_ROOT / "pipelines", "pipeline"),
120-
],
121-
"third_party": [
122-
(REPO_ROOT / "third_party" / "components", "component"),
123-
(REPO_ROOT / "third_party" / "pipelines", "pipeline"),
124-
],
125-
}
126-
127-
tiers = ["core", "third_party"] if tier == "all" else [tier]
116+
if tier not in ("core", "all"):
117+
return []
118+
119+
search_roots: List[Tuple[Path, str]] = [
120+
(REPO_ROOT / "components", "component"),
121+
(REPO_ROOT / "pipelines", "pipeline"),
122+
]
128123

129124
discovered: List[Tuple[Path, str, str]] = []
130-
for selected_tier in tiers:
131-
for root, target_kind in search_roots.get(selected_tier, []):
132-
if not root.exists():
133-
continue
134-
for metadata_path in root.glob("**/metadata.yaml"):
135-
discovered.append((metadata_path, selected_tier, target_kind))
125+
for root, target_kind in search_roots:
126+
if not root.exists():
127+
continue
128+
for metadata_path in root.glob("**/metadata.yaml"):
129+
discovered.append((metadata_path, "core", target_kind))
136130
return discovered
137131

138132

scripts/test_compile_check.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,8 @@ def _create_component(
6565
*,
6666
metadata: Dict[str, Any],
6767
body: str,
68-
tier: str = "components",
6968
) -> Path:
70-
component_root = self.repo_root / tier
69+
component_root = self.repo_root / "components"
7170
training_dir = component_root / "training"
7271
component_dir = training_dir / component_name
7372
_ensure_packages(
@@ -83,7 +82,7 @@ def _create_component(
8382

8483
base_metadata: Dict[str, Any] = {
8584
"name": component_name,
86-
"tier": "core" if tier == "components" else "third_party",
85+
"tier": "core",
8786
"stability": "stable",
8887
"ci": {"compile_check": True},
8988
}

0 commit comments

Comments
 (0)