Skip to content

Commit 0e93491

Browse files
committed
fix(ci): add missing protobuf and workspace setup steps
Several workflows were missing required setup steps: 1. kfp-sdk-client-tests.yml: Added protobuf action and workspace packages installation before running tests 2. gcpc-modules-tests.yml: Replaced manual protobuf-compiler installation with protobuf action, added workspace packages installation 3. readthedocs-builds.yml: Added protobuf action instead of manual make command 4. components/test_load_all_components.sh: Changed python3 to uv run python to use the correct virtual environment 5. setup-python/action.yml: Updated to actions/setup-python@v6 for consistency with other workflows
1 parent 5161652 commit 0e93491

File tree

5 files changed

+18
-11
lines changed

5 files changed

+18
-11
lines changed

.github/actions/setup-python/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ runs:
1212
using: "composite"
1313
steps:
1414
- name: Set up Python
15-
uses: actions/setup-python@v5
15+
uses: actions/setup-python@v6
1616
with:
1717
python-version: ${{ inputs.python-version }}
1818

.github/workflows/gcpc-modules-tests.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,12 @@ jobs:
2323
with:
2424
python-version: '3.9'
2525

26-
- name: Install protobuf-compiler
27-
run: sudo apt update && sudo apt install -y protobuf-compiler
26+
- name: Install protobuf dependencies & generate proto files
27+
uses: ./.github/actions/protobuf
2828

29-
- name: Generate API proto files
30-
working-directory: ./api
31-
run: make clean python
29+
- name: Install workspace packages
30+
run: |
31+
uv pip install --no-deps -e sdk/python -e api/v2alpha1/python -e kubernetes_platform/python -e backend/api/v2beta1/python_http_client
3232
3333
- name: Install google-cloud component
3434
run: uv pip install components/google-cloud

.github/workflows/kfp-sdk-client-tests.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,13 @@ jobs:
4444
with:
4545
python-version: '3.11'
4646

47+
- name: Install protobuf dependencies & generate proto files
48+
uses: ./.github/actions/protobuf
49+
50+
- name: Install workspace packages
51+
run: |
52+
uv pip install --no-deps -e sdk/python -e api/v2alpha1/python -e kubernetes_platform/python -e backend/api/v2beta1/python_http_client
53+
4754
- name: Create KFP cluster
4855
id: create-kfp-cluster
4956
uses: ./.github/actions/create-cluster

.github/workflows/readthedocs-builds.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,11 @@ jobs:
2424
python-version: "3.10"
2525
extra: docs
2626

27-
- name: Generate proto files and install packages
27+
- name: Install protobuf dependencies & generate proto files
28+
uses: ./.github/actions/protobuf
29+
30+
- name: Generate kfp-kubernetes proto files and install packages
2831
run: |
29-
make -C api python
3032
make -C kubernetes_platform python
3133
uv pip install --no-deps -e sdk/python -e api/v2alpha1/python -e kubernetes_platform/python -e backend/api/v2beta1/python_http_client
3234

components/test_load_all_components.sh

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,8 @@
2323

2424
cd "$(dirname "$0")"
2525

26-
PYTHONPATH="$PYTHONPATH:../sdk/python"
27-
2826
echo "Testing loading all components"
29-
find . -name component.yaml | python3 -c '
27+
find . -name component.yaml | uv run python -c '
3028
import sys
3129
import kfp
3230

0 commit comments

Comments
 (0)