Skip to content

Commit 11e2f8d

Browse files
Merge branch 'master' into click-version-update
2 parents 19376ce + 716818b commit 11e2f8d

File tree

66 files changed

+662
-632
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

66 files changed

+662
-632
lines changed

.github/actions/deploy/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ runs:
115115
if [ "${{inputs.pod_to_pod_tls_enabled }}" = "true" ]; then
116116
ARGS="${ARGS} --tls-enabled"
117117
fi
118-
echo "ARGS=$ARGS" >> $GITHUB_OUTPUT
118+
echo "ARGS=$ARGS" >> "$GITHUB_OUTPUT"
119119
120120
- name: Deploy KFP
121121
id: deploy-kfp

.github/actions/kfp-k8s/action.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
name: "Install kfp & kfp-kubernetes"
2+
description: "Install kfp & kfp-kubernetes"
23
inputs:
34
build_version:
45
required: true

.github/actions/test-and-report/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ runs:
132132
uuid=$(uuidgen)
133133
REPORT_NAME="HTML Report - ${{ github.run_id }}_${{ github.job }}_$uuid"
134134
fi
135-
echo "REPORT_NAME=$REPORT_NAME" >> $GITHUB_OUTPUT
135+
echo "REPORT_NAME=$REPORT_NAME" >> "$GITHUB_OUTPUT"
136136
137137
- name: Upload HTML Report
138138
id: upload

.github/resources/scripts/deploy-kfp.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ fi
9494
if [ -n "${AWF_VERSION}" ]; then
9595
echo "NOTE: Argo version ${AWF_VERSION} specified, updating Argo Workflow manifests..."
9696
echo "${AWF_VERSION}" > third_party/argo/VERSION
97-
make -C ./manifests/kustomize/third-party/argo update
97+
make -C ./third_party/argo update_manifests
9898
echo "Manifests updated for Argo version ${AWF_VERSION}."
9999
fi
100100

.github/workflows/add-ci-passed-label.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@ jobs:
5454
run: |
5555
pr_number=$(cat ./pr_number)
5656
event_action=$(cat ./event_action)
57-
echo "pr_number=${pr_number}" >> $GITHUB_OUTPUT
58-
echo "event_action=${event_action}" >> $GITHUB_OUTPUT
57+
echo "pr_number=${pr_number}" >> "$GITHUB_OUTPUT"
58+
echo "event_action=${event_action}" >> "$GITHUB_OUTPUT"
5959
6060
reset_ci_passed_label:
6161
name: Reset 'ci-passed' label on PR Synchronization
@@ -66,7 +66,7 @@ jobs:
6666
run: |
6767
if [[ "${{ needs.fetch_data.outputs.event_action }}" == "synchronize" || "${{ needs.fetch_data.outputs.event_action }}" == "reopened" ]]; then
6868
echo "Resetting 'ci-passed' label as changes were pushed (event: ${{ needs.fetch_data.outputs.event_action }})."
69-
gh pr edit ${{ needs.fetch_data.outputs.pr_number }} --remove-label "ci-passed" --repo $GITHUB_REPOSITORY || echo "Label not present"
69+
gh pr edit ${{ needs.fetch_data.outputs.pr_number }} --remove-label "ci-passed" --repo "$GITHUB_REPOSITORY" || echo "Label not present"
7070
fi
7171
env:
7272
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -79,6 +79,6 @@ jobs:
7979
- name: Add 'ci-passed' label
8080
run: |
8181
echo "Adding 'ci-passed' label to PR #${{ needs.fetch_data.outputs.pr_number }}"
82-
gh pr edit ${{ needs.fetch_data.outputs.pr_number }} --add-label "ci-passed" --repo $GITHUB_REPOSITORY
82+
gh pr edit ${{ needs.fetch_data.outputs.pr_number }} --add-label "ci-passed" --repo "$GITHUB_REPOSITORY"
8383
env:
8484
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/api-server-tests.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -58,16 +58,16 @@ jobs:
5858
k8s_version: [ "v1.31.0" ]
5959
cache_enabled: [ "true", "false" ]
6060
proxy: [ "true", "false" ]
61-
argo_version: [ "v3.7.1", "v3.6.10" ]
61+
argo_version: [ "v3.7.3", "v3.6.7" ]
6262
pipeline_store: [ "database" ]
6363
pod_to_pod_tls_enabled: [ "false" ]
6464
include:
6565
- k8s_version: "v1.29.2"
6666
cache_enabled: "true"
67-
argo_version: "v3.6.10"
67+
argo_version: "v3.6.7"
6868
- k8s_version: "v1.29.2"
6969
cache_enabled: "true"
70-
argo_version: "v3.5.15"
70+
argo_version: "v3.5.14"
7171
- k8s_version: "v1.31.0"
7272
cache_enabled: "true"
7373
pod_to_pod_tls_enabled: "true"
@@ -104,7 +104,7 @@ jobs:
104104
if: ${{ matrix.pod_to_pod_tls_enabled == 'true'}}
105105
run: |
106106
kubectl get secret kfp-api-tls-cert -n kubeflow -o jsonpath='{.data.ca\.crt}' | base64 -d > "${{ github.workspace }}/ca.crt"
107-
echo "CA_CERT_PATH=${{ github.workspace }}/ca.crt" >> $GITHUB_ENV
107+
echo "CA_CERT_PATH=${{ github.workspace }}/ca.crt" >> "$GITHUB_ENV"
108108
109109
- name: Configure Input Variables
110110
shell: bash
@@ -125,9 +125,11 @@ jobs:
125125
PROXY=false
126126
fi
127127
128-
echo "NUMBER_OF_NODES=$NUMBER_OF_NODES" >> $GITHUB_OUTPUT
129-
echo "TEST_LABEL=$TEST_LABEL" >> $GITHUB_OUTPUT
130-
echo "NAMESPACE=$NAMESPACE" >> $GITHUB_OUTPUT
128+
{
129+
echo "NUMBER_OF_NODES=$NUMBER_OF_NODES"
130+
echo "TEST_LABEL=$TEST_LABEL"
131+
echo "NAMESPACE=$NAMESPACE"
132+
} >> "$GITHUB_OUTPUT"
131133
132134
- name: Run Tests
133135
uses: ./.github/actions/test-and-report
@@ -162,7 +164,7 @@ jobs:
162164
k8s_version: [ "v1.31.0", "v1.29.2" ]
163165
cache_enabled: [ "true" ]
164166
uploadPipelinesWithKubernetesClient: [ "true", "false" ]
165-
argo_version: [ "v3.7.1", "v3.6.10" ]
167+
argo_version: [ "v3.7.3", "v3.6.7" ]
166168
pipeline_store: [ "kubernetes" ]
167169
pod_to_pod_tls_enabled: [ "false" ]
168170
include:
@@ -193,7 +195,6 @@ jobs:
193195
with:
194196
pipeline_store: ${{ matrix.pipeline_store }}
195197
cache_enabled: ${{ matrix.cache_enabled }}
196-
proxy: ${{ matrix.proxy }}
197198
argo_version: ${{ matrix.argo_version }}
198199
image_path: ${{ needs.build.outputs.IMAGE_PATH }}
199200
image_tag: ${{ needs.build.outputs.IMAGE_TAG }}
@@ -206,7 +207,6 @@ jobs:
206207
with:
207208
pipeline_store: ${{ matrix.pipeline_store }}
208209
cache_enabled: ${{ matrix.cache_enabled }}
209-
proxy: ${{ matrix.proxy }}
210210
test_directory: ${{ env.API_TESTS_DIR }}
211211
test_label: ${{ env.TESTS_LABEL }}
212212
num_parallel_nodes: ${{ env.NUMBER_OF_PARALLEL_NODES }}
@@ -274,4 +274,4 @@ jobs:
274274
shell: bash
275275
if: ${{ steps.test-run.outcome == 'success' }}
276276
run: |
277-
echo "::notice title=Test Summary and HTML Report is now available in the Summary Tab"
277+
echo "::notice title=Test Summary and HTML Report is now available in the Summary Tab"

.github/workflows/backend-visualization.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
uses: actions/checkout@v5
2121

2222
- name: Set up Python
23-
uses: actions/setup-python@v4
23+
uses: actions/setup-python@v6
2424
with:
2525
python-version: '3.11'
2626

.github/workflows/build-and-push.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ on:
1010
required: false
1111
target_tag:
1212
type: string
13-
default: 'X.Y.Z'
1413
description: 'Target Image Tag'
1514
required: true
1615
overwrite_imgs:
@@ -30,17 +29,14 @@ on:
3029
required: false
3130
app_to_build:
3231
type: string
33-
default: ''
3432
description: 'Provide the app name to build'
3533
required: true
3634
image_context:
3735
type: string
38-
default: ''
3936
description: 'Provide the docker file path'
4037
required: true
4138
docker_file:
4239
type: string
43-
default: ''
4440
description: 'Provide the docker file name'
4541
required: true
4642
push:
@@ -139,7 +135,7 @@ jobs:
139135
IMAGE: ${{ env.IMAGE_REGISTRY }}/${{ env.IMAGE_ORG }}/${{ inputs.app_to_build }}:${{env.TARGET_IMAGE_TAG}}
140136
OVERWRITE: ${{ env.OVERWRITE_IMAGES }}
141137
run: |
142-
if docker manifest inspect ${IMAGE} > /dev/null 2>&1; then
138+
if docker manifest inspect "${IMAGE}" > /dev/null 2>&1; then
143139
echo "Image tag already exists!"
144140
if [ "$OVERWRITE" == "false" ]; then
145141
echo "Overwrite is set to false, exiting."

.github/workflows/codeql.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040

4141
# Initializes the CodeQL tools for scanning.
4242
- name: Initialize CodeQL
43-
uses: github/codeql-action/init@v2
43+
uses: github/codeql-action/init@v2.23
4444
with:
4545
languages: ${{ matrix.language }}
4646
# If you wish to specify custom queries, you can do so here or in a config file.
@@ -54,7 +54,7 @@ jobs:
5454
# Autobuild attempts to build any compiled languages (C/C++, C#, Go, or Java).
5555
# If this step fails, then you should remove it and run the build manually (see below)
5656
- name: Autobuild
57-
uses: github/codeql-action/autobuild@v2
57+
uses: github/codeql-action/autobuild@v2.23
5858

5959
# ℹ️ Command-line programs to run using the OS shell.
6060
# 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
@@ -67,6 +67,6 @@ jobs:
6767
# ./location_of_script_within_repo/buildscript.sh
6868

6969
- name: Perform CodeQL Analysis
70-
uses: github/codeql-action/analyze@v2
70+
uses: github/codeql-action/analyze@v2.23
7171
with:
7272
category: "/language:${{matrix.language}}"

.github/workflows/compiler-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ jobs:
5252
if [ "${{ github.event_name }}" == "workflow_dispatch" ]; then
5353
TEST_LABEL=${{ inputs.test_label }}
5454
fi
55-
echo "TEST_LABEL=$TEST_LABEL" >> $GITHUB_OUTPUT
55+
echo "TEST_LABEL=$TEST_LABEL" >> "$GITHUB_OUTPUT"
5656
5757
- name: Run Tests
5858
uses: ./.github/actions/test-and-report

0 commit comments

Comments
 (0)