Skip to content

Commit 2e8e56a

Browse files
HumairAKCollinHowland
authored andcommitted
chore: remove pin on protobuf 6 ver (#12345)
* remove pin on protobuf 6 ver Signed-off-by: Humair Khan <[email protected]> * use requirements.in for kfp-k8s and spec Signed-off-by: Humair Khan <[email protected]> --------- Signed-off-by: Humair Khan <[email protected]> Signed-off-by: CollinHowland <[email protected]>
1 parent c658446 commit 2e8e56a

File tree

8 files changed

+27
-15
lines changed

8 files changed

+27
-15
lines changed

api/v2alpha1/python/MANIFEST.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
include requirements.txt
1+
include requirements.in
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
# After any updates to this file, requirements.txt should be regenerated running
2+
# the following in this folder:
3+
# pip-compile --no-emit-index-url requirements.in > requirements.txt
4+
5+
# Typically we can't support multiple major versions of protobuf
6+
# The runtime protobuf package MUST be aligned with the protobuf
7+
# libraries used to generate the code (protoc, protoc-gen-go, etc.)
8+
# For example protobuf 5.x aligns with protoc 26.x-29.x but
9+
# 6.x aligns with 30.x+.
10+
# See for support tiers:
11+
# https://protobuf.dev/support/version-support/#python
12+
protobuf>=6.31.1,<7.0
Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
# Typically we can't support multiple major versions of protobuf
2-
# The runtime protobuf package MUST be aligned with the protobuf
3-
# libraries used to generate the code (protoc, protoc-gen-go, etc.)
4-
# For example protobuf 5.x aligns with protoc 26.x-29.x but
5-
# 6.x aligns with 30.x+.
6-
# See for support tiers:
7-
# https://protobuf.dev/support/version-support/#python
8-
protobuf==6.31.1,<7.0
1+
#
2+
# This file is autogenerated by pip-compile with Python 3.9
3+
# by the following command:
4+
#
5+
# pip-compile --no-emit-index-url requirements.in
6+
#
7+
protobuf==6.31.1
8+
# via -r requirements.in

api/v2alpha1/python/setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def get_requirements(requirements_file: str) -> List[str]:
3838
url='https://github.com/kubeflow/pipelines',
3939
packages=setuptools.find_namespace_packages(include=['kfp.*']),
4040
python_requires='>=3.9.0',
41-
install_requires=get_requirements('requirements.txt'),
41+
install_requires=get_requirements('requirements.in'),
4242
include_package_data=True,
4343
license='Apache 2.0',
4444
)
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
include requirements.txt
1+
include requirements.in
22
include requirements-dev.txt

kubernetes_platform/python/requirements.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@
44

55
# protobuf version should be identical to the one in kfp-pipeline-spec
66
# api/v2alpha1/python/requirements.txt
7-
protobuf==6.31.1,<7.0
7+
protobuf>=6.31.1,<7.0
88
kfp>=2.14.5,<3

kubernetes_platform/python/setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ def read_readme() -> str:
7373
},
7474
packages=setuptools.find_namespace_packages(include=['kfp.*']),
7575
python_requires='>=3.9.0',
76-
install_requires=get_requirements('requirements.txt'),
76+
install_requires=get_requirements('requirements.in'),
7777
include_package_data=True,
7878
extras_require={
7979
'dev': get_requirements('requirements-dev.txt'),

sdk/python/requirements.in

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# the following in this folder:
33
# pip-compile --no-emit-index-url requirements.in
44

5-
click==8.1.8
5+
click>=8.1.8,<9
66
click-option-group==0.5.7
77
docstring-parser>=0.7.3,<1
88
# Pin google-api-core version for the bug fixing in 1.31.5
@@ -24,7 +24,7 @@ kfp-server-api>=2.14.3,<3
2424
kubernetes>=8.0.0,<31
2525
# protobuf version should be identical to the one in kfp-pipeline-spec
2626
# api/v2alpha1/python/requirements.txt
27-
protobuf==6.31.1,<7.0
27+
protobuf>=6.31.1,<7.0
2828
PyYAML>=5.3,<7
2929
requests-toolbelt>=0.8.0,<2
3030
tabulate>=0.8.6,<1

0 commit comments

Comments
 (0)