chore: add GH Workflow linter & format existing workflows (#12371)

* Add GH Workflow linter.

Signed-off-by: agoins <[email protected]>

* Update workflow files to address actionlint corrections.

Signed-off-by: agoins <[email protected]>

---------

Signed-off-by: agoins <[email protected]>

Author: alyssacgoins

.github/actions/deploy/action.yml

@@ -115,7 +115,7 @@ runs:
         if [ "${{inputs.pod_to_pod_tls_enabled }}" = "true" ]; then
           ARGS="${ARGS} --tls-enabled"
         fi
-        echo "ARGS=$ARGS" >> $GITHUB_OUTPUT
+        echo "ARGS=$ARGS" >> "$GITHUB_OUTPUT"
 
     - name: Deploy KFP
       id: deploy-kfp

.github/actions/kfp-k8s/action.yml

@@ -1,4 +1,5 @@
 name: "Install kfp & kfp-kubernetes"
+description: "Install kfp & kfp-kubernetes"
 inputs:
   build_version:
     required: true

.github/actions/test-and-report/action.yml

@@ -132,7 +132,7 @@ runs:
           uuid=$(uuidgen)
           REPORT_NAME="HTML Report - ${{ github.run_id }}_${{ github.job }}_$uuid"
         fi
-        echo "REPORT_NAME=$REPORT_NAME" >> $GITHUB_OUTPUT
+        echo "REPORT_NAME=$REPORT_NAME" >> "$GITHUB_OUTPUT"
 
     - name: Upload HTML Report
       id: upload

.github/workflows/add-ci-passed-label.yml

@@ -54,8 +54,8 @@ jobs:
         run: |
           pr_number=$(cat ./pr_number)
           event_action=$(cat ./event_action)
-          echo "pr_number=${pr_number}" >> $GITHUB_OUTPUT
-          echo "event_action=${event_action}" >> $GITHUB_OUTPUT
+          echo "pr_number=${pr_number}" >> "$GITHUB_OUTPUT"
+          echo "event_action=${event_action}" >> "$GITHUB_OUTPUT"
           
   reset_ci_passed_label:
     name: Reset 'ci-passed' label on PR Synchronization
@@ -66,7 +66,7 @@ jobs:
         run: |
           if [[ "${{ needs.fetch_data.outputs.event_action }}" == "synchronize" || "${{ needs.fetch_data.outputs.event_action }}" == "reopened" ]]; then
             echo "Resetting 'ci-passed' label as changes were pushed (event: ${{ needs.fetch_data.outputs.event_action }})."
-            gh pr edit ${{ needs.fetch_data.outputs.pr_number }} --remove-label "ci-passed" --repo $GITHUB_REPOSITORY || echo "Label not present"
+            gh pr edit ${{ needs.fetch_data.outputs.pr_number }} --remove-label "ci-passed" --repo "$GITHUB_REPOSITORY" || echo "Label not present"
           fi
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -79,6 +79,6 @@ jobs:
       - name: Add 'ci-passed' label
         run: |
           echo "Adding 'ci-passed' label to PR #${{ needs.fetch_data.outputs.pr_number }}"
-          gh pr edit ${{ needs.fetch_data.outputs.pr_number }} --add-label "ci-passed" --repo $GITHUB_REPOSITORY
+          gh pr edit ${{ needs.fetch_data.outputs.pr_number }} --add-label "ci-passed" --repo "$GITHUB_REPOSITORY"
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/api-server-tests.yml

@@ -104,7 +104,7 @@ jobs:
         if: ${{ matrix.pod_to_pod_tls_enabled == 'true'}}
         run: |
           kubectl get secret kfp-api-tls-cert -n kubeflow -o jsonpath='{.data.ca\.crt}' | base64 -d > "${{ github.workspace }}/ca.crt"
-          echo "CA_CERT_PATH=${{ github.workspace }}/ca.crt" >> $GITHUB_ENV
+          echo "CA_CERT_PATH=${{ github.workspace }}/ca.crt" >> "$GITHUB_ENV"
 
       - name: Configure Input Variables
         shell: bash
@@ -125,9 +125,11 @@ jobs:
             PROXY=false
           fi
           
-          echo "NUMBER_OF_NODES=$NUMBER_OF_NODES" >> $GITHUB_OUTPUT
-          echo "TEST_LABEL=$TEST_LABEL" >> $GITHUB_OUTPUT
-          echo "NAMESPACE=$NAMESPACE" >> $GITHUB_OUTPUT
+          {
+            echo "NUMBER_OF_NODES=$NUMBER_OF_NODES"
+            echo "TEST_LABEL=$TEST_LABEL"
+            echo "NAMESPACE=$NAMESPACE"
+          } >> "$GITHUB_OUTPUT"
 
       - name: Run Tests
         uses: ./.github/actions/test-and-report
@@ -193,7 +195,6 @@ jobs:
         with:
           pipeline_store: ${{ matrix.pipeline_store }}
           cache_enabled: ${{ matrix.cache_enabled }}
-          proxy: ${{ matrix.proxy }}
           argo_version: ${{ matrix.argo_version }}
           image_path: ${{ needs.build.outputs.IMAGE_PATH }}
           image_tag: ${{ needs.build.outputs.IMAGE_TAG }}
@@ -206,7 +207,6 @@ jobs:
         with:
           pipeline_store: ${{ matrix.pipeline_store }}
           cache_enabled: ${{ matrix.cache_enabled }}
-          proxy: ${{ matrix.proxy }}
           test_directory: ${{ env.API_TESTS_DIR }}
           test_label: ${{ env.TESTS_LABEL }}
           num_parallel_nodes: ${{ env.NUMBER_OF_PARALLEL_NODES }}

.github/workflows/backend-visualization.yml

@@ -20,7 +20,7 @@ jobs:
         uses: actions/checkout@v5
 
       - name: Set up Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v6
         with:
           python-version: '3.11'
 

.github/workflows/build-and-push.yml

@@ -10,7 +10,6 @@ on:
         required: false
       target_tag:
         type: string
-        default: 'X.Y.Z'
         description: 'Target Image Tag'
         required: true
       overwrite_imgs:
@@ -30,17 +29,14 @@ on:
         required: false
       app_to_build:
         type: string
-        default: ''
         description: 'Provide the app name to build'
         required: true
       image_context:
         type: string
-        default: ''
         description: 'Provide the docker file path'
         required: true
       docker_file:
         type: string
-        default: ''
         description: 'Provide the docker file name'
         required: true
       push:
@@ -139,7 +135,7 @@ jobs:
           IMAGE: ${{ env.IMAGE_REGISTRY }}/${{ env.IMAGE_ORG }}/${{ inputs.app_to_build }}:${{env.TARGET_IMAGE_TAG}}
           OVERWRITE: ${{ env.OVERWRITE_IMAGES }}
         run: |
-          if docker manifest inspect ${IMAGE} > /dev/null 2>&1; then
+          if docker manifest inspect "${IMAGE}" > /dev/null 2>&1; then
             echo "Image tag already exists!"
             if [ "$OVERWRITE" == "false" ]; then
               echo "Overwrite is set to false, exiting."

.github/workflows/codeql.yml

@@ -40,7 +40,7 @@ jobs:
 
     # Initializes the CodeQL tools for scanning.
     - name: Initialize CodeQL
-      uses: github/codeql-action/init@v2
+      uses: github/codeql-action/init@v2.23
       with:
         languages: ${{ matrix.language }}
         # If you wish to specify custom queries, you can do so here or in a config file.
@@ -54,7 +54,7 @@ jobs:
     # Autobuild attempts to build any compiled languages  (C/C++, C#, Go, or Java).
     # If this step fails, then you should remove it and run the build manually (see below)
     - name: Autobuild
-      uses: github/codeql-action/autobuild@v2
+      uses: github/codeql-action/autobuild@v2.23
 
     # ℹ️ Command-line programs to run using the OS shell.
     # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
@@ -67,6 +67,6 @@ jobs:
     #     ./location_of_script_within_repo/buildscript.sh
 
     - name: Perform CodeQL Analysis
-      uses: github/codeql-action/analyze@v2
+      uses: github/codeql-action/analyze@v2.23
       with:
         category: "/language:${{matrix.language}}"

.github/workflows/compiler-tests.yml

@@ -52,7 +52,7 @@ jobs:
           if [ "${{ github.event_name }}" == "workflow_dispatch" ]; then
             TEST_LABEL=${{ inputs.test_label }}
           fi
-          echo "TEST_LABEL=$TEST_LABEL" >> $GITHUB_OUTPUT
+          echo "TEST_LABEL=$TEST_LABEL" >> "$GITHUB_OUTPUT"
 
       - name: Run Tests
         uses: ./.github/actions/test-and-report

.github/workflows/docs-freshness.yml

@@ -17,7 +17,7 @@ jobs:
         uses: actions/checkout@v5
 
       - name: Set up Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v6
         with:
           python-version: "3.10"