Fix sdk-tests by updating with custom_path field.

Signed-off-by: agoins <[email protected]>

Author: alyssacgoins

sdk/python/kfp/dsl/executor_test.py

@@ -288,7 +288,8 @@ def test_output_metadata(self):
                   "type": {
                     "schemaTitle": "system.Metrics"
                   },
-                  "uri": "gs://some-bucket/output_artifact_two"
+                  "uri": "gs://some-bucket/output_artifact_two",
+                  "custom_path": ""
                 }
               ]
             }
@@ -594,6 +595,7 @@ def test_func(first: int, second: int) -> Dict[str, int]:
             },
         })
 
+    #TODO: Question - why does this function name end in "1"?
     def test_artifact_output1(self):
         executor_input = """\
     {
@@ -613,7 +615,8 @@ def test_artifact_output1(self):
                 "type": {
                   "schemaTitle": "system.Artifact"
                 },
-                "uri": "gs://some-bucket/output"
+                "uri": "gs://some-bucket/output",
+                "custom_path": ""
               }
             ]
           }
@@ -677,7 +680,8 @@ def test_artifact_output2(self):
                 "type": {
                   "schemaTitle": "system.Artifact"
                 },
-                "uri": "gs://some-bucket/output"
+                "uri": "gs://some-bucket/output",
+                "custom_path": ""
               }
             ]
           }
@@ -763,7 +767,8 @@ def test_named_tuple_output(self):
                     "type": {
                       "schemaTitle": "system.Dataset"
                     },
-                    "uri": "gs://some-bucket/output_dataset"
+                    "uri": "gs://some-bucket/output_dataset",
+                    "custom_path": ""
                   }
                 ]
               }
@@ -961,7 +966,8 @@ def test_component_with_input_path(self):
                                 "uri": "gs://mlpipeline/v2/artifacts/my-test-pipeline-beta/b2b0cdee-b15c-48ff-b8bc-a394ae46c854/preprocess/output_dataset_one",
                                 "metadata": {
                                     "display_name": "output_dataset_one"
-                                }
+                                },
+                                "custom_path": "uri"
                             }
                         ]
                     }
@@ -1259,7 +1265,8 @@ def test_single_artifact_output_pythonic(self):
                 "type": {
                   "schemaTitle": "system.Artifact"
                 },
-                "uri": "gs://some-bucket/output"
+                "uri": "gs://some-bucket/output",
+                "custom_path": ""
               }
             ]
           }
@@ -1290,7 +1297,8 @@ def test_func() -> Artifact:
                                 'gs://manually_specified_bucket/foo',
                             'metadata': {
                                 'data': 123
-                            }
+                            },
+                            'custom_path': ''
                         }]
                     }
                 },
@@ -1373,7 +1381,8 @@ def test_multiple_artifact_output_pythonic_with_get_uri(self):
                 "type": {
                   "schemaTitle": "system.Dataset"
                 },
-                "uri": "gs://some-bucket/output"
+                "uri": "gs://some-bucket/output",
+                "custom_path": ""
               }
             ]
           }

sdk/python/kfp/dsl/types/artifact_types.py

@@ -93,7 +93,7 @@ def path(self, path: str) -> None:
         self._set_path(path)
 
     def _get_path(self) -> Optional[str]:
-        if self.custom_path is not '':
+        if self.custom_path != '':
             return self.custom_path
         if self.uri.startswith(RemotePrefix.GCS.value):
             return _GCS_LOCAL_MOUNT_PREFIX + self.uri[len(RemotePrefix.GCS.value

test/presubmit-tests-sdk.sh

@@ -26,7 +26,7 @@ if [ "${SETUP_ENV}" = "true" ]; then
   python3 -m pip install -r sdk/python/requirements-dev.txt
   python3 -m pip install setuptools
   python3 -m pip install wheel==0.42.0
-  python3 -m pip install coveralls==4.0.1
+  python3 -m pip install coveralls==3.3.1
   python3 -m pip install --upgrade protobuf
   python3 -m pip install sdk/python