fix[frontend]: replace delete with null assignment (#12316)

* fix[frontend]: replace delete with null assignment

Signed-off-by: droctothorpe <[email protected]>
Co-authored-by: mprahl <[email protected]>

* Use the frontend from the PR in CI

Signed-off-by: mprahl <[email protected]>

* Deprecate first-interaction workflow

Signed-off-by: droctothorpe <[email protected]>

---------

Signed-off-by: droctothorpe <[email protected]>
Signed-off-by: mprahl <[email protected]>
Co-authored-by: mprahl <[email protected]>

Author: droctothorpe

.github/actions/deploy/action.yml

@@ -56,7 +56,7 @@ runs:
     - name: Load Docker Images
       shell: bash
       run: |
-        APPS=("apiserver" "driver" "launcher" "scheduledworkflow" "persistenceagent")
+        APPS=("apiserver" "driver" "launcher" "scheduledworkflow" "persistenceagent" "frontend")
         for app in "${APPS[@]}"; do
           docker image load -i ${{ inputs.image_path }}/$app/$app.tar
           docker push ${{ inputs.image_registry }}/$app:${{ inputs.image_tag }}

.github/resources/manifests/kubernetes-native/kustomization.yaml

@@ -14,6 +14,9 @@ images:
 - name: ghcr.io/kubeflow/kfp-scheduled-workflow-controller
   newName: kind-registry:5000/scheduledworkflow
   newTag: latest
+- name: ghcr.io/kubeflow/kfp-frontend
+  newName: kind-registry:5000/frontend
+  newTag: latest
 
 patches:
   - path: apiserver-env.yaml

.github/resources/manifests/multiuser/kustomization.yaml

@@ -14,6 +14,9 @@ images:
 - name: ghcr.io/kubeflow/kfp-scheduled-workflow-controller
   newName: kind-registry:5000/scheduledworkflow
   newTag: latest
+- name: ghcr.io/kubeflow/kfp-frontend
+  newName: kind-registry:5000/frontend
+  newTag: latest
 
 patches:
   - path: apiserver-env.yaml

.github/resources/manifests/multiuser/minio/kustomization.yaml

@@ -14,6 +14,9 @@ images:
 - name: ghcr.io/kubeflow/kfp-scheduled-workflow-controller
   newName: kind-registry:5000/scheduledworkflow
   newTag: latest
+- name: ghcr.io/kubeflow/kfp-frontend
+  newName: kind-registry:5000/frontend
+  newTag: latest
 
 patches:
 - path: apiserver-env.yaml

.github/resources/manifests/standalone/kustomization.yaml

@@ -14,6 +14,9 @@ images:
 - name: ghcr.io/kubeflow/kfp-scheduled-workflow-controller
   newName: kind-registry:5000/scheduledworkflow
   newTag: latest
+- name: ghcr.io/kubeflow/kfp-frontend
+  newName: kind-registry:5000/frontend
+  newTag: latest
 
 patches:
   - path: apiserver-env.yaml

.github/resources/manifests/standalone/minio/kustomization.yaml

@@ -14,6 +14,9 @@ images:
 - name: ghcr.io/kubeflow/kfp-scheduled-workflow-controller
   newName: kind-registry:5000/scheduledworkflow
   newTag: latest
+- name: ghcr.io/kubeflow/kfp-frontend
+  newName: kind-registry:5000/frontend
+  newTag: latest
 
 patches:
 - path: apiserver-env.yaml

.github/workflows/first-interaction.yml

@@ -42,6 +42,10 @@ jobs:
           - image: driver
             dockerfile: backend/Dockerfile.driver
             context: .
+
+          - image: frontend
+            dockerfile: frontend/Dockerfile
+            context: .
     env:
       ARTIFACT_NAME: "${{ matrix.image }}"
       ARTIFACTS_PATH: "images_${{ github.sha }}"

.github/workflows/image-builds-with-cache.yml

@@ -203,7 +203,7 @@ export const AuthServiceApiFetchParamCreator = function(configuration?: Configur
         options.query,
       );
       // fix override query string Detail: https://stackoverflow.com/a/7517673/1077943
-      delete localVarUrlObj.search;
+      localVarUrlObj.search = null;
       localVarRequestOptions.headers = Object.assign({}, localVarHeaderParameter, options.headers);
 
       return {