bug:Mutable Default Set Argument

[Roaimkhan]

What happened?

There are multiple instances in the codebase where wait_for_job_status implementations use a mutable set literal as a default argument:

def wait_for_job_status(
    self,
    name: str,
    status: set[str] = {constants.TRAINJOB_COMPLETE},  # ← mutable default
    ...

What did you expect to happen?

The parameter should default to None, with the real value assigned inside the function body:

def wait_for_job_status(
    self,
    name: str,
    status: set[str] | None = None,
    ...
) -> types.TrainJob:
    if status is None:
        status = {constants.TRAINJOB_COMPLETE}

This is the canonical Python pattern for mutable defaults and ensures each call gets a fresh, independent set.

Environment

nil

Impacted by this bug?

Give it a 👍 We prioritize the issues with most 👍

[github-actions]

🎉 Welcome to the Kubeflow SDK! 🎉

Thanks for opening your first issue! We're happy to have you as part of our community 🚀

Here's what happens next:

• Our team will review your issue soon! cc @kubeflow/kubeflow-sdk-team
• If you'd like to contribute to this issue, check out our Contributing Guide for repo-specific guidelines and the Kubeflow Contributor Guide for general community standards

Join the community:

• Slack: Join our #kubeflow-ml-experience and #kubeflow-trainer Slack channels
• Meetings: Attend the Kubeflow SDK and ML Experience bi-weekly meetings

Feel free to ask questions in the comments if you need any help or clarification!
Thanks again for contributing to Kubeflow! 🙏

[Srikhanth0]

Hi folks, I would like to take this on. I will hunt down the mutable default arguments in the function signatures, refactor them to use None, and initialize them inside the functions. I'll submit a PR shortly