Skip to content

Commit 1da71ce

Browse files
committed
feat: refactor some to use PodSet
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
1 parent 9274208 commit 1da71ce

File tree

8 files changed

+207
-229
lines changed

8 files changed

+207
-229
lines changed

examples/flux/lammps-train-job.yaml

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
apiVersion: trainer.kubeflow.org/v1alpha1
1212
kind: TrainJob
1313
metadata:
14-
name: lammps-flux-interactive
14+
name: lammps-flux
1515
spec:
1616
# Reference the pre-defined runtime by name
1717
runtimeRef:
@@ -21,12 +21,8 @@ spec:
2121
image: ghcr.io/converged-computing/metric-lammps:latest
2222
# You do not need to write "flux run, etc" here. It will be wrapped
2323
command: ["lmp", "-v", "x", "2", "-v", "y", "2", "-v", "z", "2", "-in", "in.reaxc.hns", "-nocite"]
24-
# Comment out the command above to make an interactive cluster! Then shell into the 0-0 pod:
25-
# # Source environment
26-
# . /mnt/flux/flux-view.sh
27-
# # Connect to the running lead broker socket
28-
# flux proxy $fluxsocket bash
29-
# # See Flux resources!
30-
# flux resource list
31-
# Run lammps!
32-
# flux run -N 4 -n 4 lmp -v x 2 -v y 2 -v z 2 -in in.reaxc.hns -nocite
24+
# See flux-interactive.yaml for running the above interactively.
25+
# This is how we match the view (operating system and verison) of the initContainer to install Flux
26+
env:
27+
- name: FLUX_VIEW_IMAGE
28+
value: ghcr.io/converged-computing/flux-view-ubuntu:tag-jammy

manifests/base/manager/manager.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ spec:
2323
containers:
2424
- name: manager
2525
image: ghcr.io/kubeflow/trainer/trainer-controller-manager
26+
# Uncomment for local development with kind
27+
# imagePullPolicy: Never
2628
securityContext:
2729
readOnlyRootFilesystem: true
2830
allowPrivilegeEscalation: false

pkg/runtime/framework/plugins/flux/command.go

Lines changed: 0 additions & 39 deletions
This file was deleted.

pkg/runtime/framework/plugins/flux/command_test.go

Lines changed: 0 additions & 62 deletions
This file was deleted.

0 commit comments

Comments
 (0)