Skip to content

chore(deps): Bump Go 1.25, k8s v1.35, and controller-runtime v0.23.1 #3127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
google-oss-prow merged 6 commits into from
Jan 27, 2026
Merged

chore(deps): Bump Go 1.25, k8s v1.35, and controller-runtime v0.23.1 #3127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
75b7f34
chore(deps): Bump Go 1.25, k8s to v1.35, and controller-runtime v0.23.1
andreyvelich Jan 26, 2026
11796ac
Migrate to new events API with EventRecorder
andreyvelich Jan 26, 2026
4d314e8
Fix RBAC for events
andreyvelich Jan 27, 2026
cb1e102
Bump k8s version in tests
andreyvelich Jan 27, 2026
05995d3
Add type compliance check
andreyvelich Jan 27, 2026
d8389db
Use Reconciling action for event
andreyvelich Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
fail-fast: false
matrix:
# Kubernetes versions for e2e tests on Kind cluster.
kubernetes-version: ["1.31.0", "1.32.3", "1.33.1", "1.34.0"]
kubernetes-version: ["1.32.3", "1.33.1", "1.34.0", "1.35.0"]

steps:
- name: Check out code
Expand Down
7 changes: 5 additions & 2 deletions .golangci-kal.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
version: "2"
run:
go: "1.24"
allow-parallel-runners: true
linters:
default: none
Expand Down Expand Up @@ -47,7 +46,11 @@ linters:
- name: "default_vs_required"
sets:
- ["default", "kubebuilder:default"]
- ["required", "kubebuilder:validation:Required", "k8s:required"]
- [
"required",
"kubebuilder:validation:Required",
"k8s:required",
]
description: "A field with a default value cannot be required"
conditions:
isFirstField: Warn # Require conditions to be the first field in the status struct.
Expand Down
1 change: 0 additions & 1 deletion .golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
version: "2"

run:
go: "1.24"
Copy link
Member

@tenzen-y tenzen-y Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to remove this?

Copy link
Member Author

@andreyvelich andreyvelich Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have it in Kueue: https://github.com/kubernetes-sigs/kueue/blob/main/.golangci.yaml
I was thinking that it is better to maintain Go version in a go.mod file only.
WDYT @tenzen-y?

Copy link
Member

@tenzen-y tenzen-y Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no preference here. I'm asking if you faced any problems or not.

Copy link
Member Author

@andreyvelich andreyvelich Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to be working fine, so I prefer to remove it from .golangci.yaml

Copy link
Contributor

@astefanutti astefanutti Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It defaults to use Go version from the go.mod file so it's probably better to remove it.

allow-parallel-runners: true

issues:
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ For the Kubeflow Trainer documentation, please check [the official Kubeflow docu

## Requirements

- [Go](https://golang.org/) (1.24 or later)
- [Go](https://golang.org/) (1.25 or later)
- [Docker](https://docs.docker.com/) (23 or later)
- [Lima](https://github.com/lima-vm/lima?tab=readme-ov-file#adopters) (an alternative to DockerDesktop) (0.21.0 or later)
- [Colima](https://github.com/abiosoft/colima) (Lima specifically for MacOS) (0.6.8 or later)
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ TRAINER_CHART_DIR := $(PROJECT_DIR)/charts/kubeflow-trainer
LOCALBIN ?= $(PROJECT_DIR)/bin

# Tool versions
K8S_VERSION ?= 1.34.0
K8S_VERSION ?= 1.35.0
GINKGO_VERSION ?= $(shell go list -m -f '{{.Version}}' github.com/onsi/ginkgo/v2)
ENVTEST_VERSION ?= release-0.22
CONTROLLER_GEN_VERSION ?= v0.18.0
Expand Down
135 changes: 98 additions & 37 deletions api/openapi-spec/swagger.json
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion api/python_api/kubeflow_trainer_api/models/__init__.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions api/python_api/kubeflow_trainer_api/models/io_k8s_api_autoscaling_v2_hpa_scaling_rules.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion api/python_api/kubeflow_trainer_api/models/io_k8s_api_batch_v1_job_spec.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...ow_trainer_api/models/io_k8s_api_batch_v1_pod_failure_policy_on_pod_conditions_pattern.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion api/python_api/kubeflow_trainer_api/models/io_k8s_api_core_v1_container.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading