-
Notifications
You must be signed in to change notification settings - Fork 903
fix(#3940): Add release navigation links to _index.md #4274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(#3940): Add release navigation links to _index.md #4274
Conversation
|
Hi @Sapthagiri777. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
🚫 This command cannot be processed. Only organization members or owners can use the commands. |
Arhell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
5d51ffe to
4bc8547
Compare
|
Hi @thesuperzapper @zijianjoy @Arhell , just pushed a fix for the DCO sign-off that was failing earlier. Everything looks good now on my end. Let me know if there's anything else needed - happy to make changes. Thanks! |
|
You are missing at least 1.10 and 1.11 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @juliusvonkohout, thanks for the feedback! I've added the missing links for 1.10 and 1.11 now. |
|
Please rebase (not merge) to master and see if that helps. |
- Fixed 'file not found' error in releases directory - Added navigation links for Kubeflow 0.6-1.9 - Verified diff shows all 12 links added - Closes kubeflow#3940 Signed-off-by: Sapthagiri777 <[email protected]>
Signed-off-by: Sapthagiri777 <[email protected]>
744924b to
f7d3061
Compare
|
@juliusvonkohout, I've rebased to master as you suggested. The rebase went through fine, but the Netlify deploy is still failing with the same submodule error (No url found for submodule path 'kserve'). Looks like this might be a repo-level issue with the .gitmodules config. Is there anything else I can try, or does this need to be fixed upstream first? |
|
Please align with @varodrig i am currently catching up on a lot of tasks. |

fix(#3940): Add release navigation links to _index.md
Description of Changes
Added missing release navigation links to
content/en/docs/kubeflow-platform/releases/_index.md.The releases page was empty (just frontmatter) causing "file not found" errors during versioning.
Related Issues
Closes: #3940
Checklist
Sapthagiri777 (Jaeger CNCF contributor - 3 PRs merged)