Inhibiting Blockers and Node Annotation Blockers#1145
Open
D3luxee wants to merge 3 commits intokubereboot:mainfrom
Open
Inhibiting Blockers and Node Annotation Blockers#1145D3luxee wants to merge 3 commits intokubereboot:mainfrom
D3luxee wants to merge 3 commits intokubereboot:mainfrom
Conversation
D3luxee
force-pushed
the
blocking_node_annotation
branch
from
21eec48 to
bba1f03
Compare
evrardjp
added
the
FEATURE-v2
Signed-off-by: Georg Doser <georg.doser@nitrado.net>
Inhibiting blockers will only block the final reboot command not the draining of nodes. Signed-off-by: Georg Doser <georg.doser@nitrado.net>
…dition Signed-off-by: Georg Doser <georg.doser@nitrado.net>
D3luxee
force-pushed
the
blocking_node_annotation
branch
from
0699368 to
ac17245
Compare
|
This PR was automatically considered stale due to lack of activity. Please refresh it and/or join our slack channels to highlight it, before it automatically closes (in 7 days). |
|
This PR was automatically considered stale due to lack of activity. Please refresh it and/or join our slack channels to highlight it, before it automatically closes (in 7 days). |
dharsanb
added
keep
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the concept of "Inhibiting Blockers" and implements the node annotation blocker.
We have the use case in which we have to drain the node and once all pods are gone some final work will be done on the node. In cloud we have the cluster-autoscaler.kubernetes.io/scale-down-disabled annotation to prevent the cluster autoscaler to scale down to early.
We needed a similar mechanism for baremetal with kured so the idea was to also let kured check for a configured annotation and block the reboot.
However the current implementation of blockers also block draining the node so i had to introduce a new type of Blockers which i named "Inhibiting Blockers" in the flags.
This code was build and verified in one of our dev clusters.
This PR might also be a starting point to resolve #1130
I will also provide the necessary changes on the helm chart once i know that the flags etc will stay with the names.