Skip to content

Fix for corev1.Endpoints is deprecated: This API is deprecated in v1.33+. Use discoveryv1.EndpointSlice. #1960

@archups

Description

@archups

Post Go controller-runtime package bump go get -v sigs.k8s.io/[email protected] which bumped the Go k8s.io packages dependencies to v0.34.0, following staticcheck issues are reported via golangci-lint which are now deferred (by adding to exclusions.rules in .golangci.yml) should be fixed.

level=info msg="[runner] linters took 1m7.664069005s with stages: goanalysis_metalinter: 1m7.660562161s"
pkg/clusterinfo/configmap.go:123:35: SA1019: corev1.EndpointSubset is deprecated: This API is deprecated in v1.33+. (staticcheck)
func getSecurePort(endpointSubset corev1.EndpointSubset) *corev1.EndpointPort {
                                  ^
pkg/clusterinfo/configmap_test.go:85:31: SA1019: corev1.Endpoints is deprecated: This API is deprecated in v1.33+. Use discoveryv1.EndpointSlice. (staticcheck)
			objects: []runtime.Object{&corev1.Endpoints{
			                           ^
pkg/clusterinfo/configmap_test.go:90:16: SA1019: corev1.EndpointSubset is deprecated: This API is deprecated in v1.33+. (staticcheck)
				Subsets: []corev1.EndpointSubset{
				           ^
3 issues:
* staticcheck: 3

To reproduce the issue, remove the following entries from .golangci.yml under exclusions.rules.

- path: (.+)\.go$
        text: 'SA1019: corev1.Endpoints is deprecated: This API is deprecated in v1.33+.'
      - path: (.+)\.go$
        text: 'SA1019: corev1.EndpointSubset is deprecated: This API is deprecated in v1.33+.'

Metadata

Metadata

Assignees

No one assigned

    Labels

    sig/cluster-managementDenotes a PR or issue as being assigned to SIG Cluster Management.

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions