refactor: update WatcherExt class to internal and remove obsolete attributes; improve example method signature in Program.cs

Author: lqlive

examples/clientset/Program.cs

@@ -23,7 +23,7 @@ private static async Task Main(string[] args)
             System.Console.WriteLine(pod?.Metadata?.Name);
 
             var watch = clientSet.CoreV1.Pod.WatchListAsync("default");
-            await foreach (var (_, item)in watch.ConfigureAwait(false))
+            await foreach (var (_, item) in watch.ConfigureAwait(false))
             {
                 System.Console.WriteLine(item.Metadata.Name);
             }

src/KubernetesClient/WatcherExt.cs

@@ -2,7 +2,7 @@
 
 namespace k8s
 {
-    public static class WatcherExt
+    internal static class WatcherExt
     {
         /// <summary>
         /// create a watch object from a call to api server with watch=true
@@ -16,7 +16,6 @@ public static class WatcherExt
         /// The action to invoke when the server closes the connection.
         /// </param>
         /// <returns>a watch object</returns>
-        [Obsolete("This method will be deprecated in future versions.")] 
         public static Watcher<T> Watch<T, L>(
             this Task<HttpOperationResponse<L>> responseTask,
             Action<WatchEventType, T> onEvent,
@@ -53,7 +52,6 @@ private static Func<Task<TextReader>> MakeStreamReaderCreator<T, L>(Task<HttpOpe
         /// The action to invoke when the server closes the connection.
         /// </param>
         /// <returns>a watch object</returns>
-        [Obsolete("This method will be deprecated in future versions.")] 
         public static Watcher<T> Watch<T, L>(
             this HttpOperationResponse<L> response,
             Action<WatchEventType, T> onEvent,
@@ -73,7 +71,6 @@ public static Watcher<T> Watch<T, L>(
         /// <param name="onError">a callback when any exception was caught during watching</param>
         /// <param name="cancellationToken">cancellation token</param>
         /// <returns>IAsyncEnumerable of watch events</returns>
-        [Obsolete("This method will be deprecated in future versions.")] 
         public static IAsyncEnumerable<(WatchEventType, T)> WatchAsync<T, L>(
             this Task<HttpOperationResponse<L>> responseTask,
             Action<Exception> onError = null,

src/LibKubernetesGenerator/TypeHelper.cs

@@ -122,7 +122,6 @@ private string GetDotNetType(JsonSchema schema, JsonSchemaProperty parent)
                     return $"IDictionary<string, {GetDotNetType(schema.AdditionalPropertiesSchema, parent)}>";
                 }
 
-
                 if (schema?.Reference != null)
                 {
                     return classNameHelper.GetClassNameForSchemaDefinition(schema.Reference);
@@ -306,7 +305,7 @@ private string TryGetItemTypeFromSchema(OpenApiResponse response)
             {
                 return classNameHelper.GetClassNameForSchemaDefinition(itemsProperty.Reference);
             }
-            
+
             if (itemsProperty.Item?.Reference != null)
             {
                 return classNameHelper.GetClassNameForSchemaDefinition(itemsProperty.Item.Reference);

tests/KubernetesClient.Tests/WatchTests.cs

@@ -732,7 +732,7 @@ protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage reques
         }
 
         [Fact]
-        public void MustHttp2VersionSet()
+        public async Task MustHttp2VersionSet()
         {
             var server = new MockKubeApiServer(testOutput, async httpContext =>
             {
@@ -747,6 +747,7 @@ public void MustHttp2VersionSet()
             Assert.Null(handler.Version);
             using var watcher = client.CoreV1.WatchListNamespacedPod("default", onEvent: (type, item) => { });
             Assert.Equal(HttpVersion.Version20, handler.Version);
+            await Task.CompletedTask.ConfigureAwait(true);
         }
 
         [Fact]