Style fix1 (#512)

* fix SA1505 and SA1508

* fix SA1116

* fix SA1009

* fix SA1019

* fix SA1127

* fix SA1128

* fix SA1134

* fix indent

* allow CA2227

* fix CA1810

* using clean up

* fix naming

* fix CA1806

* fix await

* Revert "fix CA1806"

This reverts commit a3b4650.

* fix dotnet format

* allow SA1009

Author: tg123

examples/logs/Logs.cs

@@ -1,5 +1,4 @@
 using System;
-using System.IO;
 using System.Threading.Tasks;
 using k8s;
 
@@ -22,7 +21,8 @@ private static async Task Main(string[] args)
 
             var pod = list.Items[0];
 
-            var response = await client.ReadNamespacedPodLogWithHttpMessagesAsync(pod.Metadata.Name,
+            var response = await client.ReadNamespacedPodLogWithHttpMessagesAsync(
+                pod.Metadata.Name,
                 pod.Metadata.NamespaceProperty, follow: true).ConfigureAwait(false);
             var stream = response.Body;
             stream.CopyTo(Console.OpenStandardOutput());

kubernetes-client.ruleset

@@ -106,7 +106,7 @@
     <Rule Id="SA1314" Action="None" />
 
     <!-- A C# using directive is placed outside of a namespace element. https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1200.md -->
-    <Rule Id="SA1200" Action="Warning" />
+    <Rule Id="SA1200" Action="Error" />
 
     <!-- An element within a C# code file is out of order in relation to the other elements in the code. https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1201.md -->
     <Rule Id="SA1201" Action="None" />
@@ -175,7 +175,7 @@
     <Rule Id="SA1001" Action="Warning" />
 
     <!-- A closing parenthesis within a C# statement is not spaced correctly. https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1009.md -->
-    <Rule Id="SA1009" Action="Warning" />
+    <Rule Id="SA1009" Action="None" />
 
     <!-- An opening brace within a C# element is not spaced correctly. https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1012.md -->
     <Rule Id="SA1012" Action="Warning" />
@@ -205,10 +205,10 @@
     <Rule Id="CA2225" Action="None" />
 
     <!-- Collection properties should be read only https://docs.microsoft.com/en-us/visualstudio/code-quality/CA2227 -->
-    <Rule Id="CA2227" Action="Warning" />
+    <Rule Id="CA2227" Action="None" />
 
     <!-- Mark ISerializable types with SerializableAttribute https://docs.microsoft.com/en-us/visualstudio/code-quality/CA2237 -->
-    <Rule Id="CA2237" Action="Warning" />
+    <Rule Id="CA2237" Action="None" />
 
     <!-- Do Not Disable Certificate Validation https://docs.microsoft.com/en-us/visualstudio/code-quality/CA5359 -->
     <Rule Id="CA5359" Action="None" />

src/KubernetesClient/Authentication/TokenFileAuth.cs

@@ -18,7 +18,7 @@ public TokenFileAuth(string tokenFile)
             TokenFile = tokenFile;
         }
 
-        public async Task<AuthenticationHeaderValue> GetAuthenticationHeaderAsync(CancellationToken cancellationToken)
+        public Task<AuthenticationHeaderValue> GetAuthenticationHeaderAsync(CancellationToken cancellationToken)
         {
             if (TokenExpiresAt < DateTime.UtcNow)
             {
@@ -32,7 +32,7 @@ public async Task<AuthenticationHeaderValue> GetAuthenticationHeaderAsync(Cancel
                 TokenExpiresAt = DateTime.UtcNow.AddMinutes(1);
             }
 
-            return new AuthenticationHeaderValue("Bearer", token);
+            return Task.FromResult(new AuthenticationHeaderValue("Bearer", token));
         }
     }
 }

src/KubernetesClient/ByteBuffer.cs

@@ -282,7 +282,8 @@ private void Grow(int size)
                 Array.Copy(this.buffer, 0, newBuffer, 0, this.WriteWaterMark);
 
                 int trailingDataLength = this.buffer.Length - this.ReadWaterMark;
-                Array.Copy(this.buffer,
+                Array.Copy(
+                    this.buffer,
                     sourceIndex: this.ReadWaterMark,
                     destinationArray: newBuffer,
                     destinationIndex: newBuffer.Length - trailingDataLength,

src/KubernetesClient/CertUtils.cs

@@ -5,10 +5,8 @@
 using Org.BouncyCastle.Security;
 using Org.BouncyCastle.X509;
 using System;
-using System.Collections.Generic;
 using System.IO;
 using System.Security.Cryptography.X509Certificates;
-using System.Text.RegularExpressions;
 
 namespace k8s
 {

src/KubernetesClient/Exceptions/KubeConfigException.cs

@@ -1,7 +1,7 @@
+using System;
+
 namespace k8s.Exceptions
 {
-    using System;
-
     /// <summary>
     /// The exception that is thrown when the kube config is invalid
     /// </summary>

src/KubernetesClient/Exceptions/KubernetesClientException.cs

@@ -1,7 +1,7 @@
+using System;
+
 namespace k8s.Exceptions
 {
-    using System;
-
     /// <summary>
     /// The exception that is thrown when there is a client exception
     /// </summary>

src/KubernetesClient/Extensions.cs

@@ -1,22 +1,15 @@
 using System;
-using System.Collections.Concurrent;
-using System.Linq;
-using System.Net;
-using System.Net.Http;
 using System.Reflection;
 using System.Text.RegularExpressions;
-using System.Threading.Tasks;
 using k8s.Models;
-using Microsoft.Rest;
-using Microsoft.Rest.TransientFaultHandling;
-using Newtonsoft.Json.Converters;
-using VersionConverter = k8s.Versioning.VersionConverter;
 
 namespace k8s
 {
     public static class Extensions
     {
-        public static KubernetesEntityAttribute GetKubernetesTypeMetadata<T>(this T obj) where T : IKubernetesObject =>
+        public static KubernetesEntityAttribute GetKubernetesTypeMetadata<T>(this T obj)
+            where T : IKubernetesObject
+            =>
             obj.GetType().GetKubernetesTypeMetadata();
         public static KubernetesEntityAttribute GetKubernetesTypeMetadata(this Type currentType)
         {
@@ -29,7 +22,8 @@ public static KubernetesEntityAttribute GetKubernetesTypeMetadata(this Type curr
             return attr;
         }
 
-        public static T Initialize<T>(this T obj) where T : IKubernetesObject
+        public static T Initialize<T>(this T obj)
+            where T : IKubernetesObject
         {
             var metadata = obj.GetKubernetesTypeMetadata();
             obj.ApiVersion = !string.IsNullOrEmpty(metadata.Group) ? $"{metadata.Group}/{metadata.ApiVersion}" : metadata.ApiVersion;

src/KubernetesClient/IntstrIntOrString.cs

@@ -1,7 +1,5 @@
 using System;
 using Newtonsoft.Json;
-using YamlDotNet.Core.Events;
-using YamlDotNet.Core.Tokens;
 
 namespace k8s.Models
 {

src/KubernetesClient/KubeConfigModels/AuthProvider.cs

@@ -1,9 +1,8 @@
+using System.Collections.Generic;
+using YamlDotNet.Serialization;
+
 namespace k8s.KubeConfigModels
 {
-    using System.Collections.Generic;
-    using YamlDotNet.RepresentationModel;
-    using YamlDotNet.Serialization;
-
     /// <summary>
     /// Contains information that describes identity information.  This is use to tell the kubernetes cluster who you are.
     /// </summary>