overwrite existing external process environment variables to prevent throwing when a key is present that is already set (#520)

chris-smith-zocdoc · web-flow · commit 19854da0a1a3 · 2020-11-13T08:32:25.000-08:00
diff --git a/src/KubernetesClient/KubernetesClientConfiguration.ConfigFile.cs b/src/KubernetesClient/KubernetesClientConfiguration.ConfigFile.cs
@@ -442,9 +442,8 @@ public static Process CreateRunnableExternalProcess(ExternalExecution config)
                 {
                     if (configEnvironmentVariable.ContainsKey("name") && configEnvironmentVariable.ContainsKey("value"))
                     {
-                        process.StartInfo.EnvironmentVariables.Add(
-                            configEnvironmentVariable["name"],
-                            configEnvironmentVariable["value"]);
+                        var name = configEnvironmentVariable["name"];
+                        process.StartInfo.EnvironmentVariables[name] = configEnvironmentVariable["value"];
                     }
                     else
                     {

Original file line number	Diff line number	Diff line change
`@@ -442,9 +442,8 @@ public static Process CreateRunnableExternalProcess(ExternalExecution config)`
`442`	`442`	`{`
`443`	`443`	`if (configEnvironmentVariable.ContainsKey("name") && configEnvironmentVariable.ContainsKey("value"))`
`444`	`444`	`{`
`445`		`- process.StartInfo.EnvironmentVariables.Add(`
`446`		`- configEnvironmentVariable["name"],`
`447`		`- configEnvironmentVariable["value"]);`
	`445`	`+ var name = configEnvironmentVariable["name"];`
	`446`	`+ process.StartInfo.EnvironmentVariables[name] = configEnvironmentVariable["value"];`
`448`	`447`	`}`
`449`	`448`	`else`
`450`	`449`	`{`