Skip to content

Commit 218395a

Browse files
Address code review feedback and improve tests
Co-authored-by: brendandburns <[email protected]>
1 parent a4a5fc2 commit 218395a

File tree

1 file changed

+2
-30
lines changed

1 file changed

+2
-30
lines changed

tests/Kubectl.Tests/KubectlTests.Get.cs

Lines changed: 2 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -30,17 +30,6 @@ public void GetPod()
3030
var namespaceParameter = "default";
3131
var podName = "k8scsharp-e2e-get-pod";
3232

33-
// Cleanup any existing pod
34-
try
35-
{
36-
kubernetes.CoreV1.DeleteNamespacedPod(podName, namespaceParameter);
37-
System.Threading.Thread.Sleep(2000);
38-
}
39-
catch
40-
{
41-
// Ignore if pod doesn't exist
42-
}
43-
4433
// Create a test pod
4534
var pod = new V1Pod
4635
{
@@ -62,12 +51,9 @@ public void GetPod()
6251
},
6352
};
6453

65-
kubernetes.CoreV1.CreateNamespacedPod(pod, namespaceParameter);
66-
6754
try
6855
{
69-
// Wait a moment for the pod to be created
70-
System.Threading.Thread.Sleep(1000);
56+
kubernetes.CoreV1.CreateNamespacedPod(pod, namespaceParameter);
7157

7258
// Get the pod using kubectl
7359
var retrievedPod = client.GetPod(podName, namespaceParameter);
@@ -100,17 +86,6 @@ public void GetService()
10086
var namespaceParameter = "default";
10187
var serviceName = "k8scsharp-e2e-get-service";
10288

103-
// Cleanup any existing service
104-
try
105-
{
106-
kubernetes.CoreV1.DeleteNamespacedService(serviceName, namespaceParameter);
107-
System.Threading.Thread.Sleep(1000);
108-
}
109-
catch
110-
{
111-
// Ignore if service doesn't exist
112-
}
113-
11489
// Create a test service
11590
var service = new V1Service
11691
{
@@ -136,12 +111,9 @@ public void GetService()
136111
},
137112
};
138113

139-
kubernetes.CoreV1.CreateNamespacedService(service, namespaceParameter);
140-
141114
try
142115
{
143-
// Wait a moment for the service to be created
144-
System.Threading.Thread.Sleep(1000);
116+
kubernetes.CoreV1.CreateNamespacedService(service, namespaceParameter);
145117

146118
// Get the service using kubectl
147119
var retrievedService = client.GetService(serviceName, namespaceParameter);

0 commit comments

Comments
 (0)