Standardization of using order and object initialization (#1028)

* Code cleanup KubernetesClient

* KubernetesClient.Basic code cleanup

* KubernetesClient.Models cleanup

* LibKubernetesGenerator code cleanup

* Improved readability of object initialization

* FIx namespace order

* Fixed some compilation warning

Author: m3nax

examples/namespace/NamespaceExample.cs

@@ -35,9 +35,9 @@ private static async Task DeleteAsync(IKubernetes client, string name, int delay
                 {
                     foreach (var innerEx in ex.InnerExceptions)
                     {
-                        if (innerEx is k8s.Autorest.HttpOperationException)
+                        if (innerEx is k8s.Autorest.HttpOperationException exception)
                         {
-                            var code = ((k8s.Autorest.HttpOperationException)innerEx).Response.StatusCode;
+                            var code = exception.Response.StatusCode;
                             if (code == HttpStatusCode.NotFound)
                             {
                                 return;

examples/yaml/Program.cs

@@ -10,10 +10,12 @@ internal class Program
     {
         private static async Task Main(string[] args)
         {
-            var typeMap = new Dictionary<String, Type>();
-            typeMap.Add("v1/Pod", typeof(V1Pod));
-            typeMap.Add("v1/Service", typeof(V1Service));
-            typeMap.Add("apps/v1/Deployment", typeof(V1Deployment));
+            var typeMap = new Dictionary<String, Type>
+            {
+                { "v1/Pod", typeof(V1Pod) },
+                { "v1/Service", typeof(V1Service) },
+                { "apps/v1/Deployment", typeof(V1Deployment) }
+            };
 
             var objects = await KubernetesYaml.LoadAllFromFileAsync(args[0], typeMap);
 

src/KubernetesClient.Basic/AbstractKubernetes.cs

@@ -19,7 +19,7 @@ private static class HttpMethods
 
     private sealed class QueryBuilder
     {
-        private List<string> parameters = new List<string>();
+        private readonly List<string> parameters = new List<string>();
 
         public void Append(string key, params object[] values)
         {

src/KubernetesClient.Basic/Autorest/HttpRequestMessageWrapper.cs

@@ -30,12 +30,10 @@ public HttpRequestMessageWrapper(HttpRequestMessage httpRequest, string content)
             this.Content = content;
             this.Method = httpRequest.Method;
             this.RequestUri = httpRequest.RequestUri;
-#pragma warning disable CS0618 // Type or member is obsolete
             if (httpRequest.Properties != null)
             {
                 Properties = new Dictionary<string, object>();
                 foreach (KeyValuePair<string, object> pair in httpRequest.Properties)
-#pragma warning restore CS0618 // Type or member is obsolete
                 {
                     this.Properties[pair.Key] = pair.Value;
                 }

src/KubernetesClient.Basic/Autorest/TokenCredentials.cs

@@ -98,7 +98,7 @@ public TokenCredentials(ITokenProvider tokenProvider, string tenantId, string ca
         /// <returns>
         /// Task that will complete when processing has completed.
         /// </returns>
-        public async override Task ProcessHttpRequestAsync(
+        public override async Task ProcessHttpRequestAsync(
             HttpRequestMessage request,
             CancellationToken cancellationToken)
         {

src/KubernetesClient.Basic/Global.cs

@@ -1,8 +1,8 @@
-global using System;
-global using System.Collections.Generic;
-global using System.Linq;
 global using k8s.Autorest;
 global using k8s.Models;
+global using System;
+global using System.Collections.Generic;
 global using System.IO;
+global using System.Linq;
 global using System.Threading;
 global using System.Threading.Tasks;

src/KubernetesClient.Models/Extensions.cs

@@ -1,6 +1,6 @@
+using k8s.Models;
 using System.Reflection;
 using System.Text.RegularExpressions;
-using k8s.Models;
 
 namespace k8s
 {

src/KubernetesClient.Models/IItems.cs

@@ -17,6 +17,11 @@ public static class ItemsExt
     {
         public static IEnumerator<T> GetEnumerator<T>(this IItems<T> items)
         {
+            if (items is null)
+            {
+                throw new ArgumentNullException(nameof(items));
+            }
+
             return items.Items.GetEnumerator();
         }
     }

src/KubernetesClient.Models/KubeConfigModels/ExecCredentialResponse.cs

@@ -13,8 +13,8 @@ public class ExecStatus
 
             public bool IsValid()
             {
-                return (!string.IsNullOrEmpty(Token) ||
-                        (!string.IsNullOrEmpty(ClientCertificateData) && !string.IsNullOrEmpty(ClientKeyData)));
+                return !string.IsNullOrEmpty(Token) ||
+                        (!string.IsNullOrEmpty(ClientCertificateData) && !string.IsNullOrEmpty(ClientKeyData));
             }
         }
 

src/KubernetesClient.Models/KubernetesYaml.cs

@@ -1,3 +1,4 @@
+using k8s.Models;
 using System.IO;
 using System.Reflection;
 using System.Text;
@@ -6,7 +7,6 @@
 using YamlDotNet.Core.Events;
 using YamlDotNet.Serialization;
 using YamlDotNet.Serialization.NamingConventions;
-using k8s.Models;
 
 namespace k8s
 {