Skip to content

Commit 5513cfe

Browse files
committed
migrate test proj to net5 base
1 parent f5e2671 commit 5513cfe

File tree

4 files changed

+20
-22
lines changed

4 files changed

+20
-22
lines changed

src/KubernetesClient/KubernetesClient.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<PackageIconUrl>https://raw.githubusercontent.com/kubernetes/kubernetes/master/logo/logo.png</PackageIconUrl>
1010
<PackageTags>kubernetes;docker;containers;</PackageTags>
1111

12-
<TargetFrameworks>netstandard2.0;netstandard2.1;net5</TargetFrameworks>
12+
<TargetFrameworks>netstandard2.0;netstandard2.1</TargetFrameworks>
1313
<RootNamespace>k8s</RootNamespace>
1414
<SignAssembly>true</SignAssembly>
1515
<GenerateDocumentationFile>true</GenerateDocumentationFile>

tests/KubernetesClient.Tests/KubernetesClient.Tests.csproj

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,14 @@
1-
<Project Sdk="Microsoft.NET.Sdk">
1+
<Project Sdk="Microsoft.NET.Sdk.Web">
22
<PropertyGroup>
33
<IsPackable>false</IsPackable>
44
<LangVersion>8</LangVersion>
55
<SignAssembly>true</SignAssembly>
66
<RootNamespace>k8s.Tests</RootNamespace>
7-
<TargetFrameworks>netcoreapp2.1</TargetFrameworks>
7+
<TargetFrameworks>net5</TargetFrameworks>
88
</PropertyGroup>
99

1010
<ItemGroup>
1111
<PackageReference Include="FluentAssertions" Version="5.10.3" />
12-
<PackageReference Include="Microsoft.AspNetCore.All" Version="2.0.9">
13-
<!-- this is due to aspnet core 2.1 is not compatible with our code -->
14-
<AllowExplicitVersion>true</AllowExplicitVersion>
15-
</PackageReference>
16-
1712
<PackageReference Include="Microsoft.Extensions.Logging" Version="2.2.0" />
1813
<PackageReference Include="System.Reactive" Version="4.3.2" />
1914
<PackageReference Include="Nito.AsyncEx" Version="5.1.0" />

tests/KubernetesClient.Tests/KubernetesExecTests.cs

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -48,17 +48,18 @@ public async Task WebSocketNamespacedPodExecAsync()
4848
tty: true,
4949
customHeaders: new Dictionary<string, List<string>>()
5050
{
51-
{"X-My-Header", new List<string>() {"myHeaderValue", "myHeaderValue2" } },
51+
{ "X-My-Header", new List<string>() { "myHeaderValue", "myHeaderValue2" } },
5252
},
5353
cancellationToken: CancellationToken.None).ConfigureAwait(false);
5454

5555
var expectedHeaders = new Dictionary<string, string>()
5656
{
57-
{"X-My-Header", "myHeaderValue myHeaderValue2" },
58-
{"Authorization", "Basic bXktdXNlcjpteS1zZWNyZXQtcGFzc3dvcmQ=" },
57+
{ "X-My-Header", "myHeaderValue myHeaderValue2" },
58+
{ "Authorization", "Basic bXktdXNlcjpteS1zZWNyZXQtcGFzc3dvcmQ=" },
5959
};
6060

61-
Assert.Equal(mockWebSocketBuilder.PublicWebSocket,
61+
Assert.Equal(
62+
mockWebSocketBuilder.PublicWebSocket,
6263
webSocket); // Did the method return the correct web socket?
6364
Assert.Equal(
6465
new Uri(
@@ -89,17 +90,18 @@ public async Task WebSocketNamespacedPodPortForwardAsync()
8990
ports: new int[] { 80, 8080 },
9091
customHeaders: new Dictionary<string, List<string>>()
9192
{
92-
{"X-My-Header", new List<string>() {"myHeaderValue", "myHeaderValue2" } },
93+
{ "X-My-Header", new List<string>() { "myHeaderValue", "myHeaderValue2" } },
9394
},
9495
cancellationToken: CancellationToken.None).ConfigureAwait(false);
9596

9697
var expectedHeaders = new Dictionary<string, string>()
9798
{
98-
{"X-My-Header", "myHeaderValue myHeaderValue2" },
99-
{"Authorization", "Basic bXktdXNlcjpteS1zZWNyZXQtcGFzc3dvcmQ=" },
99+
{ "X-My-Header", "myHeaderValue myHeaderValue2" },
100+
{ "Authorization", "Basic bXktdXNlcjpteS1zZWNyZXQtcGFzc3dvcmQ=" },
100101
};
101102

102-
Assert.Equal(mockWebSocketBuilder.PublicWebSocket,
103+
Assert.Equal(
104+
mockWebSocketBuilder.PublicWebSocket,
103105
webSocket); // Did the method return the correct web socket?
104106
Assert.Equal(
105107
new Uri("ws://localhost/api/v1/namespaces/mynamespace/pods/mypod/portforward?ports=80&ports=8080"),
@@ -133,17 +135,18 @@ public async Task WebSocketNamespacedPodAttachAsync()
133135
tty: true,
134136
customHeaders: new Dictionary<string, List<string>>()
135137
{
136-
{"X-My-Header", new List<string>() {"myHeaderValue", "myHeaderValue2" } },
138+
{ "X-My-Header", new List<string>() { "myHeaderValue", "myHeaderValue2" } },
137139
},
138140
cancellationToken: CancellationToken.None).ConfigureAwait(false);
139141

140142
var expectedHeaders = new Dictionary<string, string>()
141143
{
142-
{"X-My-Header", "myHeaderValue myHeaderValue2" },
143-
{"Authorization", "Basic bXktdXNlcjpteS1zZWNyZXQtcGFzc3dvcmQ=" },
144+
{ "X-My-Header", "myHeaderValue myHeaderValue2" },
145+
{ "Authorization", "Basic bXktdXNlcjpteS1zZWNyZXQtcGFzc3dvcmQ=" },
144146
};
145147

146-
Assert.Equal(mockWebSocketBuilder.PublicWebSocket,
148+
Assert.Equal(
149+
mockWebSocketBuilder.PublicWebSocket,
147150
webSocket); // Did the method return the correct web socket?
148151
Assert.Equal(
149152
new Uri(

tests/KubernetesClient.Tests/Mock/Server/Startup.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
using Microsoft.Extensions.DependencyInjection;
33
using Microsoft.Extensions.Logging;
44
using System;
5+
using Microsoft.AspNetCore.Mvc;
56

67
namespace k8s.Tests.Mock.Server
78
{
@@ -35,7 +36,7 @@ public static void ConfigureServices(IServiceCollection services)
3536
{
3637
logging.ClearProviders(); // Logger provider will be added by the calling test.
3738
});
38-
services.AddMvc();
39+
services.AddMvc(opt => opt.EnableEndpointRouting = false);
3940
}
4041

4142
/// <summary>
@@ -49,7 +50,6 @@ public static void Configure(IApplicationBuilder app)
4950
app.UseWebSockets(new WebSocketOptions
5051
{
5152
KeepAliveInterval = TimeSpan.FromSeconds(5),
52-
ReceiveBufferSize = 2048,
5353
});
5454
app.UseMvc();
5555
}

0 commit comments

Comments
 (0)