Skip to content

Commit 7717e65

Browse files
Merge pull request #15 from sesispla/master
Fixed two remaining unit tests
2 parents 4c60ce9 + c108755 commit 7717e65

File tree

4 files changed

+6
-7
lines changed

4 files changed

+6
-7
lines changed

README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
# csharp
22
Work In Progress
3-
Currently only supported on Linux
3+
Currently only supported on Linux
4+
5+
[![Travis](https://img.shields.io/travis/kubernetes-client/csharp.svg)](https://travis-ci.org/kubernetes-client/csharp)
46

57
# Generating the client code
68

src/KubernetesClientCredentials.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public KubernetesClientCredentials(string userName, string password)
3232
throw new ArgumentNullException(nameof(userName));
3333
}
3434

35-
if (string.IsNullOrWhiteSpace(userName))
35+
if (string.IsNullOrWhiteSpace(password))
3636
{
3737
throw new ArgumentNullException(nameof(password));
3838
}

tests/KubernetesClientConfigurationTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public class KubernetesClientConfigurationTests
4848
/// </summary>
4949
private static readonly string kubeConfigTlsNoSkipError = "assets/kubeconfig.tls-no-skip-error.yml";
5050

51-
/// <summary>
51+
/// <summary>
5252
/// Sample configuration file with incorrect TLS configuration in cluster section
5353
/// </summary>
5454
private static readonly string kubeConfigTlsSkip = "assets/kubeconfig.tls-skip.yml";
@@ -69,7 +69,7 @@ public void ConfigurationFileNotFound()
6969
[Fact]
7070
public void DefaultConfigurationLoaded()
7171
{
72-
var cfg = new KubernetesClientConfiguration();
72+
var cfg = new KubernetesClientConfiguration(new FileInfo(kubeConfigFileName));
7373
Assert.NotNull(cfg.Host);
7474
}
7575

tests/tests.csproj

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@
44
<IsPackable>false</IsPackable>
55
</PropertyGroup>
66
<ItemGroup>
7-
<PackageReference Include="Microsoft.Rest.ClientRuntime" Version="3.0.3" />
8-
<PackageReference Include="Newtonsoft.Json" Version="10.0.2" />
9-
<PackageReference Include="YamlDotNet.NetCore" Version="1.0.0" />
107
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.0.0" />
118
<PackageReference Include="xunit" Version="2.3.0-beta3-build3705" />
129
<PackageReference Include="xunit.runner.visualstudio" Version="2.3.0-beta3-build3705" />

0 commit comments

Comments
 (0)