From 9dd128cf66e4279da995f16259988f6d110d65b9 Mon Sep 17 00:00:00 2001 From: Boshi Lian Date: Tue, 11 Feb 2025 03:00:42 -0800 Subject: [PATCH 1/3] Update upload-artifact action to version 4 in buildtest workflow --- .github/workflows/buildtest.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/buildtest.yaml b/.github/workflows/buildtest.yaml index 05224a51e..4a50a301e 100644 --- a/.github/workflows/buildtest.yaml +++ b/.github/workflows/buildtest.yaml @@ -31,7 +31,7 @@ jobs: directory: ./TestResults files: '*.cobertura.xml' - name: Upload test results - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: test-results path: ./TestResults From 71fb4d4261e95ebfa772f58060bae79de130cc36 Mon Sep 17 00:00:00 2001 From: Boshi Lian Date: Tue, 11 Feb 2025 03:27:54 -0800 Subject: [PATCH 2/3] Disable parallel build for E2E tests in buildtest workflow --- .github/workflows/buildtest.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/buildtest.yaml b/.github/workflows/buildtest.yaml index 4a50a301e..cce87fb7d 100644 --- a/.github/workflows/buildtest.yaml +++ b/.github/workflows/buildtest.yaml @@ -73,7 +73,7 @@ jobs: - name: Test run: | true > skip.log - env K8S_E2E_MINIKUBE=1 dotnet test tests/E2E.Tests --logger "SkipTestLogger;file=$PWD/skip.log" + env K8S_E2E_MINIKUBE=1 dotnet test tests/E2E.Tests --logger "SkipTestLogger;file=$PWD/skip.log" -p:BuildInParallel=false if [ -s skip.log ]; then cat skip.log echo "CASES MUST NOT BE SKIPPED" @@ -82,7 +82,7 @@ jobs: - name: AOT Test run: | true > skip.log - env K8S_E2E_MINIKUBE=1 dotnet test tests/E2E.Aot.Tests --logger "SkipTestLogger;file=$PWD/skip.log" + env K8S_E2E_MINIKUBE=1 dotnet test tests/E2E.Aot.Tests --logger "SkipTestLogger;file=$PWD/skip.log" -p:BuildInParallel=false if [ -s skip.log ]; then cat skip.log echo "CASES MUST NOT BE SKIPPED" From 6521d631ad8f3ac1c4ff6df7b79345d943e52992 Mon Sep 17 00:00:00 2001 From: Boshi Lian Date: Tue, 11 Feb 2025 03:29:53 -0800 Subject: [PATCH 3/3] Update artifact name to include OS in buildtest workflow --- .github/workflows/buildtest.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/buildtest.yaml b/.github/workflows/buildtest.yaml index cce87fb7d..a31e0e50f 100644 --- a/.github/workflows/buildtest.yaml +++ b/.github/workflows/buildtest.yaml @@ -33,7 +33,7 @@ jobs: - name: Upload test results uses: actions/upload-artifact@v4 with: - name: test-results + name: test-results-${{ matrix.os }} path: ./TestResults if: ${{ always() }} # Always run this step even on failure