Remove extra Quantity.fromString() call

davidxia · davidxia · commit 07a9d0f9298e · 2018-11-04T07:57:41.000-05:00
in Quantity constructor. Avoid doing extra work.
We only need to call it once.
diff --git a/kubernetes/src/main/java/io/kubernetes/client/custom/Quantity.java b/kubernetes/src/main/java/io/kubernetes/client/custom/Quantity.java
@@ -37,8 +37,9 @@ public Quantity(final BigDecimal number, final Format format) {
   }
 
   public Quantity(final String value) {
-    this.number = fromString(value).number;
-    this.format = fromString(value).format;
+    final Quantity quantity = fromString(value);
+    this.number = quantity.number;
+    this.format = quantity.format;
   }
 
   public BigDecimal getNumber() {

Original file line number	Diff line number	Diff line change
`@@ -37,8 +37,9 @@ public Quantity(final BigDecimal number, final Format format) {`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`public Quantity(final String value) {`
`40`		`- this.number = fromString(value).number;`
`41`		`- this.format = fromString(value).format;`
	`40`	`+ final Quantity quantity = fromString(value);`
	`41`	`+ this.number = quantity.number;`
	`42`	`+ this.format = quantity.format;`
`42`	`43`	`}`
`43`	`44`
`44`	`45`	`public BigDecimal getNumber() {`