Merge pull request #1626 from aaruna/latchCountdownFixControllerManager

Add more debug/error logs and ensure controllerManager shutdown in case of exception

Author: k8s-ci-robot

extended/src/main/java/io/kubernetes/client/extended/controller/ControllerManager.java

@@ -61,17 +61,24 @@ public void run() {
     for (Controller controller : this.controllers) {
       controllerThreadPool.submit(
           () -> {
-            controller.run();
-            latch.countDown();
+            try {
+              log.debug("Starting controller manager");
+              controller.run();
+            } catch (Throwable t) {
+              log.error("Unexpected controller termination", t);
+            } finally {
+              latch.countDown();
+              log.debug("Exiting controller manager");
+            }
           });
     }
     try {
-      log.debug("Controller-Manager {} bootstrapping..");
+      log.debug("Controller-Manager bootstrapping.");
       latch.await();
     } catch (InterruptedException e) {
       log.error("Aborting controller-manager.", e);
     } finally {
-      log.info("Controller-Manager {} exited");
+      log.info("Controller-Manager exited");
     }
   }
 }

extended/src/main/java/io/kubernetes/client/extended/controller/DefaultController.java

@@ -154,9 +154,10 @@ public void run() {
               this.worker();
             } catch (Throwable t) {
               log.error("Unexpected controller loop abortion", t);
+            } finally {
+              latch.countDown();
+              log.debug("Exiting controller {} worker {}..", this.name, workerIndex);
             }
-            latch.countDown();
-            log.debug("Exiting controller {} worker {}..", this.name, workerIndex);
           },
           0,
           1,