Skip to content

Commit 28b9ec8

Browse files
author
Dave Syer
committed
Added explicit runtime dependency for logback
The samples will not log anything when they run without a logging library. Logback is only in test scope because of the parent pom (I think). So we need to add it back explicitly. Signed-off-by: Dave Syer <[email protected]>
1 parent 8183197 commit 28b9ec8

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

examples/examples-release-12/pom.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,11 @@
1717
</properties>
1818

1919
<dependencies>
20+
<dependency>
21+
<groupId>ch.qos.logback</groupId>
22+
<artifactId>logback-classic</artifactId>
23+
<scope>runtime</scope>
24+
</dependency>
2025
<dependency>
2126
<groupId>io.prometheus</groupId>
2227
<artifactId>simpleclient</artifactId>

examples/examples-release-13/pom.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,11 @@
1717
</properties>
1818

1919
<dependencies>
20+
<dependency>
21+
<groupId>ch.qos.logback</groupId>
22+
<artifactId>logback-classic</artifactId>
23+
<scope>runtime</scope>
24+
</dependency>
2025
<dependency>
2126
<groupId>io.prometheus</groupId>
2227
<artifactId>simpleclient</artifactId>

0 commit comments

Comments
 (0)