Skip to content

Commit 31addf4

Browse files
Passed deleteOptions to deleteNamespacedCustomObject and expand delete testcase to check for url verify
1 parent 28aba9d commit 31addf4

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

extended/src/main/java/io/kubernetes/client/extended/kubectl/KubectlDelete.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,6 @@ private void verifyArguments() throws KubectlException {
8080
if (null == name) {
8181
throw new KubectlException("missing name argument");
8282
}
83-
83+
8484
}
8585
}

extended/src/test/java/io/kubernetes/client/extended/kubectl/KubectlDeleteTest.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,10 @@ void kubectlDelete() throws KubectlException, ApiException {
213213
deleteOptions.setPropagationPolicy("Foreground");
214214
kubectlDelete.deleteOptions(deleteOptions);
215215
kubectlDelete.execute();
216-
216+
apiServer.verify(
217+
1,
218+
deleteRequestedFor(urlPathEqualTo("/apis/batch%2Fv1/batch%2Fv1/namespaces/foo/jobs/bar"))
219+
.withRequestBody(equalToJson("{\"propagationPolicy\" : \"Foreground\"}")));
217220
assertThatThrownBy(() -> {
218221
KubectlDelete<V1Job> kubectlDelete2 = Kubectl.delete(V1Job.class);
219222
kubectlDelete2.apiClient(apiClient);

util/src/main/java/io/kubernetes/client/util/generic/GenericKubernetesApi.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1159,6 +1159,7 @@ private CallBuilder makeNamespacedDeleteCallBuilder(
11591159
namespace,
11601160
this.resourcePlural,
11611161
name)
1162+
.body(deleteOptions)
11621163
// TODO: fill/convert the option
11631164
.buildCall(null);
11641165
}

0 commit comments

Comments
 (0)