Clean up the code (#1059)

Author: dddddai

examples/src/main/java/io/kubernetes/client/examples/ExecExample.java

@@ -19,8 +19,6 @@
 import io.kubernetes.client.openapi.Configuration;
 import io.kubernetes.client.util.Config;
 import java.io.IOException;
-import java.util.ArrayList;
-import java.util.List;
 import org.apache.commons.cli.CommandLine;
 import org.apache.commons.cli.CommandLineParser;
 import org.apache.commons.cli.DefaultParser;
@@ -48,12 +46,7 @@ public static void main(String[] args)
 
     String podName = cmd.getOptionValue("p", "nginx-dbddb74b8-s4cx5");
     String namespace = cmd.getOptionValue("n", "default");
-    List<String> commands = new ArrayList<>();
-
     args = cmd.getArgs();
-    for (int i = 0; i < args.length; i++) {
-      commands.add(args[i]);
-    }
 
     ApiClient client = Config.defaultClient();
     Configuration.setDefaultApiClient(client);
@@ -63,14 +56,7 @@ public static void main(String[] args)
     // final Process proc = exec.exec("default", "nginx-4217019353-k5sn9", new String[]
     //   {"sh", "-c", "echo foo"}, true, tty);
     final Process proc =
-        exec.exec(
-            namespace,
-            podName,
-            commands.isEmpty()
-                ? new String[] {"sh"}
-                : commands.toArray(new String[commands.size()]),
-            true,
-            tty);
+        exec.exec(namespace, podName, args.length == 0 ? new String[] {"sh"} : args, true, tty);
 
     Thread in =
         new Thread(

util/src/main/java/io/kubernetes/client/Copy.java

@@ -203,8 +203,6 @@ public void copyFileToPod(
     } finally {
       proc.destroy();
     }
-
-    return;
   }
 
   private boolean isTarPresentInContainer(String namespace, String pod, String container)
@@ -215,7 +213,7 @@ private boolean isTarPresentInContainer(String namespace, String pod, String con
     // This will work for POSIX based operating systems
     try {
       int status = proc.waitFor();
-      return status == 127 ? false : true;
+      return status != 127;
     } catch (InterruptedException ex) {
       throw new IOException(ex);
     } finally {

util/src/main/java/io/kubernetes/client/PortForward.java

@@ -110,7 +110,7 @@ public PortForwardResult forward(String namespace, String name, List<Integer> po
     String path = makePath(namespace, name);
     WebSocketStreamHandler handler = new WebSocketStreamHandler();
     PortForwardResult result = new PortForwardResult(handler, ports);
-    List<Pair> queryParams = new ArrayList<>();
+    List<Pair> queryParams = new ArrayList<>(ports.size());
     for (Integer port : ports) {
       queryParams.add(new Pair("ports", port.toString()));
     }

util/src/main/java/io/kubernetes/client/informer/cache/SharedProcessor.java

@@ -111,7 +111,7 @@ public boolean shouldResync() {
     lock.writeLock().lock();
     boolean resyncNeeded = false;
     try {
-      this.syncingListeners = new ArrayList<>();
+      this.syncingListeners = new ArrayList<>(this.listeners.size());
 
       DateTime now = DateTime.now();
       for (ProcessorListener listener : this.listeners) {