Skip to content

Commit 5df0a6d

Browse files
authored
Merge pull request #2645 from v1ku/fix-delete-label-issue
Fixed bug: label being set as null instead of deleted
2 parents 019f2a1 + 5b8da07 commit 5df0a6d

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

extended/src/main/java/io/kubernetes/client/extended/kubectl/KubectlLabel.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public KubectlLabel<ApiType> addLabel(String key, String value) {
3838
}
3939

4040
public KubectlLabel<ApiType> deleteLabel(String key) {
41-
this.addingLabels.put(key, "null");
41+
this.addingLabels.remove(key);
4242
return this;
4343
}
4444

extended/src/test/java/io/kubernetes/client/extended/kubectl/KubectlLabelTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ public void testKubectlDeleteLabelNamespacedResourceShouldWork() throws KubectlE
9191
wireMockRule.stubFor(
9292
put(urlPathEqualTo("/api/v1/namespaces/default/pods/foo"))
9393
.withRequestBody(
94-
matchingJsonPath("$.metadata.labels", equalToJson("{ \"k1\": \"null\" }")))
94+
matchingJsonPath("$.metadata.labels", equalToJson("{}")))
9595
.willReturn(
9696
aResponse()
9797
.withStatus(200)
@@ -174,7 +174,7 @@ public void testKubectlDeleteLabelClusterResourceShouldWork() throws KubectlExce
174174
wireMockRule.stubFor(
175175
put(urlPathEqualTo("/api/v1/nodes/foo"))
176176
.withRequestBody(
177-
matchingJsonPath("$.metadata.labels", equalToJson("{ \"k1\": \"null\" }")))
177+
matchingJsonPath("$.metadata.labels", equalToJson("{}")))
178178
.willReturn(aResponse().withStatus(200).withBody("{\"metadata\":{\"name\":\"foo\"}}")));
179179

180180
V1Node unlabelledNode =

0 commit comments

Comments
 (0)