Skip to content

Commit 6476e16

Browse files
authored
Merge pull request #1051 from sarveshkaushal/master
Removing duplicate code
2 parents 06281a7 + 4b97ae3 commit 6476e16

File tree

1 file changed

+7
-11
lines changed

1 file changed

+7
-11
lines changed

util/src/main/java/io/kubernetes/client/ProtoClient.java

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
import com.google.common.io.ByteStreams;
1717
import com.google.common.primitives.Bytes;
1818
import com.google.protobuf.Message;
19+
import com.google.protobuf.Message.Builder;
1920
import io.kubernetes.client.openapi.ApiClient;
2021
import io.kubernetes.client.openapi.ApiException;
2122
import io.kubernetes.client.openapi.Configuration;
@@ -210,17 +211,7 @@ public <T extends Message> ObjectOrStatus<T> delete(
210211
byte[] bytes = encode(deleteOptions, "v1", "DeleteOptions");
211212
request =
212213
request.newBuilder().delete(RequestBody.create(MediaType.parse(MEDIA_TYPE), bytes)).build();
213-
Response resp = apiClient.getHttpClient().newCall(request).execute();
214-
Unknown u = parse(resp.body().byteStream());
215-
resp.body().close();
216-
217-
if (u.getTypeMeta().getApiVersion().equals("v1")
218-
&& u.getTypeMeta().getKind().equals("Status")) {
219-
Status status = Status.newBuilder().mergeFrom(u.getRaw()).build();
220-
return new ObjectOrStatus(null, status);
221-
}
222-
223-
return new ObjectOrStatus((T) builder.mergeFrom(u.getRaw()).build(), null);
214+
return getObjectOrStatusFromServer(builder, request);
224215
}
225216

226217
/**
@@ -284,6 +275,11 @@ public <T extends Message> ObjectOrStatus<T> request(
284275
throw new ApiException("Unknown proto client API method: " + method);
285276
}
286277
}
278+
return getObjectOrStatusFromServer(builder, request);
279+
}
280+
281+
private <T extends Message> ObjectOrStatus<T> getObjectOrStatusFromServer(
282+
Builder builder, Request request) throws IOException, ApiException {
287283
Response resp = apiClient.getHttpClient().newCall(request).execute();
288284
Unknown u = parse(resp.body().byteStream());
289285
resp.body().close();

0 commit comments

Comments
 (0)