Skip to content

Commit 6b9579b

Browse files
committed
refactor: use StandardCharsets
1 parent 7a86d30 commit 6b9579b

File tree

5 files changed

+9
-6
lines changed

5 files changed

+9
-6
lines changed

util/src/main/java/io/kubernetes/client/Exec.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
import java.io.UnsupportedEncodingException;
3636
import java.lang.reflect.Type;
3737
import java.net.URLEncoder;
38+
import java.nio.charset.StandardCharsets;
3839
import java.util.Arrays;
3940
import java.util.HashMap;
4041
import java.util.List;
@@ -438,7 +439,7 @@ private String makePath() {
438439
String[] encodedCommand = new String[command.length];
439440
for (int i = 0; i < command.length; i++) {
440441
try {
441-
encodedCommand[i] = URLEncoder.encode(command[i], "UTF-8");
442+
encodedCommand[i] = URLEncoder.encode(command[i], StandardCharsets.UTF_8);
442443
} catch (UnsupportedEncodingException ex) {
443444
throw new RuntimeException("some thing wrong happend: " + ex.getMessage());
444445
}
@@ -614,7 +615,7 @@ public OutputStream getResizeStream() {
614615
public void resize(int width, int height) throws IOException {
615616
OutputStream resizeStream = getResizeStream();
616617
String resize = "{ \"width\": " + width + ", \"height\": " + height + " }\n";
617-
resizeStream.write(resize.getBytes("UTF-8"));
618+
resizeStream.write(resize.getBytes(StandardCharsets.UTF_8));
618619
resizeStream.flush();
619620
}
620621

util/src/main/java/io/kubernetes/client/util/ModelMapper.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import java.net.URI;
2828
import java.net.URL;
2929
import java.net.URLDecoder;
30+
import java.nio.charset.StandardCharsets;
3031
import java.time.Duration;
3132
import java.util.ArrayList;
3233
import java.util.Enumeration;
@@ -491,7 +492,7 @@ private static List<String> getClassNamesFromPackage(ClassLoader classLoader, St
491492
}
492493

493494
private static void processJarPackage(URL packageURL, String packageName, String pkg, ArrayList<String> names) throws IOException {
494-
String jarFileName = URLDecoder.decode(packageURL.getFile(), "UTF-8");
495+
String jarFileName = URLDecoder.decode(packageURL.getFile(), StandardCharsets.UTF_8);
495496
JarFile jf = null;
496497
// jar: client in repository; nested: client in a fat jar
497498
if (jarFileName.startsWith("jar:") || jarFileName.startsWith("nested:")) {

util/src/main/java/io/kubernetes/client/util/authenticators/OpenIDConnectAuthenticator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ private JSONObject refreshOidcToken(
216216
String urlData =
217217
new StringBuilder()
218218
.append("refresh_token=")
219-
.append(URLEncoder.encode(refreshToken, "UTF-8"))
219+
.append(URLEncoder.encode(refreshToken, StandardCharsets.UTF_8))
220220
.append("&grant_type=refresh_token")
221221
.toString();
222222
OutputStream ou = https.getOutputStream();

util/src/test/java/io/kubernetes/client/ExecTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ void terminalResize() throws IOException, InterruptedException {
172172
process.resize(100, 100);
173173
process.destroy();
174174

175-
String out = bos.toString("UTF-8");
175+
String out = bos.toString(StandardCharsets.UTF_8);
176176
assertThat(out).isEqualTo("{ \"width\": 100, \"height\": 100 }\n");
177177
}
178178

util/src/test/java/io/kubernetes/client/WebsocketStreamHandlerTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import java.io.InputStream;
2222
import java.io.OutputStream;
2323
import java.nio.charset.Charset;
24+
import java.nio.charset.StandardCharsets;
2425
import okhttp3.Request;
2526
import okhttp3.WebSocket;
2627
import okio.ByteString;
@@ -68,7 +69,7 @@ void handlerSendingData() throws IOException {
6869

6970
OutputStream outputStream = handler.getOutputStream(testStreamId);
7071

71-
byte[] bytes = "This is a test string".getBytes("UTF-8");
72+
byte[] bytes = "This is a test string".getBytes(StandardCharsets.UTF_8);
7273
byte[] output = new byte[bytes.length + 1];
7374
output[0] = 0;
7475
for (int i = 0; i < bytes.length; i++) {

0 commit comments

Comments
 (0)