Skip to content

Commit 7444026

Browse files
authored
Merge pull request #1429 from yue9944882/allow-custom-registry-injection
Removes prometheus actuator endpoints
2 parents 5333aca + e7e34b7 commit 7444026

File tree

3 files changed

+6
-85
lines changed

3 files changed

+6
-85
lines changed

spring/src/main/java/io/kubernetes/client/spring/extended/controller/config/ConditionalOnActuatorPrometheusEndpointEnabled.java

Lines changed: 0 additions & 28 deletions
This file was deleted.

spring/src/main/java/io/kubernetes/client/spring/extended/controller/config/KubernetesReconcilerAutoConfiguration.java

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
*/
1313
package io.kubernetes.client.spring.extended.controller.config;
1414

15-
import io.kubernetes.client.spring.extended.controller.metrics.PrometheusScrapeEndpoint;
15+
import io.prometheus.client.CollectorRegistry;
1616
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
1717
import org.springframework.context.annotation.Bean;
1818
import org.springframework.context.annotation.Configuration;
@@ -21,14 +21,10 @@
2121
@ConditionalOnKubernetesReconcilerEnabled
2222
public class KubernetesReconcilerAutoConfiguration {
2323

24-
@Configuration(proxyBeanMethods = false)
25-
@ConditionalOnActuatorPrometheusEndpointEnabled
26-
public static class KubernetesActuatorPrometheusConfiguration {
27-
28-
@Bean
29-
@ConditionalOnMissingBean
30-
public PrometheusScrapeEndpoint prometheusScrapeEndpoint() {
31-
return new PrometheusScrapeEndpoint();
32-
}
24+
@Bean
25+
@ConditionalOnMissingBean
26+
public CollectorRegistry prometheusCollectorRegistry() {
27+
// Explicitly uses default static registry by default
28+
return CollectorRegistry.defaultRegistry;
3329
}
3430
}

spring/src/main/java/io/kubernetes/client/spring/extended/controller/metrics/PrometheusScrapeEndpoint.java

Lines changed: 0 additions & 47 deletions
This file was deleted.

0 commit comments

Comments
 (0)